Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WiFi Ethernet fix MAC address reversed order #980

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

pennam
Copy link
Contributor

@pennam pennam commented Oct 25, 2024

MACAddress is deprecated keeping the original reversed behaviour.
uint8_t* macAddress(uint8_t * mac) returns byte aligned with String macAddress()

@JAndrassy
Copy link
Contributor

MACAddress(buff) is legacy Ethernet API, macAddress(buff) is WiFi API.
WiFi API has the MAC bytes reversed in WiFi, WiFi101 and WiFiNINA library (and here in Mbed Core)
Ethernet API never had the MAC address reversed.

so this solution preserves the error in PortnetaEthernet library and for Mbed Core WiFi library this PR changes the behavior of the macAddress function (and the 'tradition' of reversed MAC in WiFi libraries).

so I guess there isn't a good solution for this. I would just remove the reversion completely.

@pennam
Copy link
Contributor Author

pennam commented Oct 25, 2024

Ethernet API never had the MAC address reversed.

Thanks @JAndrassy i will doublecheck it, I was assuming it was reversed also in Ethernet library

My goal was primarly to align the behaviour of macAddress at least between mbed and renesas core. At this point I suppose is it better to introduce the "reverse tradition" in the renesas WiFi library

@JAndrassy
Copy link
Contributor

JAndrassy commented Oct 25, 2024

t this point I suppose is it better to introduce the "reverse tradition" in the renesas WiFi library

we removed it recently for compatibility with esp32, esp8266, rp2040 ...

@pennam
Copy link
Contributor Author

pennam commented Oct 25, 2024

we removed it recently

yeah i've disagreed with myself one second after writing this 🙂

I will doublecheck the Ethernet MACAddress behaviour , It feels a bit strange to me that is not reversing the byte order since it is using the same socketWrapper function used in WiFi macAddress but maybe it get twisted one more time before.

@JAndrassy
Copy link
Contributor

I meant Ethernet API in general. the Wiznet Ethernet library, the UIPEtherner etc

@pennam
Copy link
Contributor Author

pennam commented Oct 25, 2024

ah ok, got it!

@pennam pennam changed the title WiFi Ethernet deprecate MACAddress(...) in favour of macAddres(...) WiFi Ethernet fix MAC address reversed order Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants