Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): Bump arduino/setup-task from 1 to 2 #2361

Closed

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 8, 2024

Bumps arduino/setup-task from 1 to 2.

Release notes

Sourced from arduino/setup-task's releases.

2.0.0

Migration Guide

The version of the Node.js runtime used to execute the action has been updated from 16 to 20. This could be a breaking change for certain GitHub Actions workflows.

If a workflow with dependency on the arduino/setup-task action uses only GitHub-hosted GitHub Actions runners, no changes are required.

If the workflow uses a self-hosted runner, the workflow run might fail after updating arduino/setup-task:

Error: System.ArgumentOutOfRangeException: Specified argument was out of the range of valid values. (Parameter ''using: node20' is not supported, use 'docker', 'node12' or 'node16' instead.')
   at GitHub.Runner.Worker.ActionManifestManager.ConvertRuns(IExecutionContext executionContext, TemplateContext templateContext, TemplateToken inputsToken, String fileRelativePath, MappingToken outputs)
   at GitHub.Runner.Worker.ActionManifestManager.Load(IExecutionContext executionContext, String manifestFile)
Error: Fail to load arduino/setup-task/v2/action.yml

This means an older runner version that does not provide Node.js 20.x is installed on the runner machine and you must update the runner version.

Changelog

Breaking

  • Update Node.js runtime for action from 16 to 20 (#919)

Enhancement

Full Changeset

arduino/setup-task@1.0.3...2.0.0

Contributors

1.0.3

Changelog

Enhancement

  • Add support for all Task build architectures (43e1bb8c37ce39c24e88b4622c2f66b6d7d9ebbd)

Full Changeset

arduino/setup-task@1.0.2...1.0.3

1.0.2

Release Notes

... (truncated)

Commits
  • b91d5d2 update readme (#929)
  • f2514b0 Bump node from 16 to 20 (#919)
  • 2007903 Merge pull request #928 from arduino/dependabot/npm_and_yarn/prettier-3.2.5
  • 3f2ef95 build(deps-dev): bump prettier from 3.2.2 to 3.2.5
  • 88d658b Merge pull request #927 from arduino/dependabot/npm_and_yarn/types/node-16.18.79
  • b79a1c3 build(deps-dev): bump @​types/node from 16.18.78 to 16.18.79
  • 5abddba Merge pull request #926 from arduino/dependabot/npm_and_yarn/types/node-16.18.78
  • b3e99c0 build(deps-dev): bump @​types/node from 16.18.76 to 16.18.78
  • 4145542 Merge pull request #924 from arduino/dependabot/npm_and_yarn/typescript-eslin...
  • 10406e6 build(deps-dev): bump @​typescript-eslint/parser from 6.19.1 to 6.20.0
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [arduino/setup-task](https://github.com/arduino/setup-task) from 1 to 2.
- [Release notes](https://github.com/arduino/setup-task/releases)
- [Commits](arduino/setup-task@v1.0.0...v2)

---
updated-dependencies:
- dependency-name: arduino/setup-task
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the topic: infrastructure Related to project infrastructure label Feb 8, 2024
@per1234 per1234 added the type: enhancement Proposed improvement label Feb 9, 2024
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Linux build of Arduino IDE is dynamically linked against the glibc shared library. This results in it having a dependency on the version of the library that happens to be present in the environment it is built in. The container the Linux build runs in is intentionally configured to have an older version of glibc (#2253). This provides compatibility with a reasonable range of older distro versions that might be present on the Linux machines of Arduino IDE users (newer versions of glibc are compatible with executables linked against an older version but the reverse is not true).

Unfortunately version 2.x of the arduino/setup-task GitHub Actions action used by the build job has a dependency on a higher version of glibc than is provided by the Linux container. That dependency mismatch is the case of the error that occurs at the action's step in the job after the bump proposed by this PR:

https://github.com/arduino/arduino-ide/actions/runs/7835103589/job/21379778533?pr=2361#step:10:83

Run arduino/setup-task@v2
/usr/bin/docker exec  7384d1a7dd09d45a5a6797b3710bfb7dee6ec5d176149e01b297f3685cf161ae sh -c "cat /etc/*release | grep ^ID"
/__e/node20/bin/node: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.28' not found (required by /__e/node20/bin/node)

This is the reason the workflow was intentionally configured to use arduino/setup-task@v1 for the Linux build job (#2351). So it is necessary to decline this bump.

Dependabot will remember this decision and only submit another PR for bumping arduino/setup-task at such time the action has another major version bump (i.e., v2 -> v3). At that time, we should accept the bump in all workflow steps other than this specific step, which must remain at arduino/setup-task@v1 unless we eventually abandon support for the older distro versions and update the container so that a newer version of glibc is available.

@per1234
Copy link
Contributor

per1234 commented Feb 9, 2024

https://github.com/dependabot ignore this major version

@dependabot dependabot bot closed this Feb 9, 2024
Copy link
Contributor Author

dependabot bot commented on behalf of github Feb 9, 2024

OK, I won't notify you about version 2.x.x again, unless you re-open this PR.

@dependabot dependabot bot deleted the dependabot/github_actions/arduino/setup-task-2 branch February 9, 2024 02:10
@per1234 per1234 added the conclusion: invalid Issue/PR not valid label Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: invalid Issue/PR not valid topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant