Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: webwallet trpc #33

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

janek26
Copy link
Contributor

@janek26 janek26 commented Nov 23, 2023

No description provided.

@@ -49,12 +49,11 @@ export const setPopupOptions = ({

// TODO: abstract AppRouter in order to have one single source of truth
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor: update the comment

@@ -68,44 +68,51 @@ export const StarknetMethodArgumentsSchemas = {
z
.object({
starknetVersion: z
.union([z.literal("v4"), z.literal("v5")])
.union([z.literal("v3"), z.literal("v4")])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same question as @vladutjs here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants