Return update errors

Signed-off-by: Tommy Chen <tommy351@gmail.com>
argoproj-labs · Apr 29, 2024 · bf3091a · bf3091a
1 parent b2477b9
commit bf3091a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/pkg/plugin/httproute.go b/pkg/plugin/httproute.go
@@ -54,6 +54,9 @@ func (r *RpcPlugin) setHTTPRouteWeight(rollout *v1alpha1.Rollout, desiredWeight
 	if err != nil {
 		msg := fmt.Sprintf(GatewayAPIUpdateError, httpRoute.GetName(), err)
 		r.LogCtx.Error(msg)
+		return pluginTypes.RpcError{
+			ErrorString: err.Error(),
+		}
 	}
 	return pluginTypes.RpcError{}
 }

diff --git a/pkg/plugin/tcproute.go b/pkg/plugin/tcproute.go
@@ -48,6 +48,9 @@ func (r *RpcPlugin) setTCPRouteWeight(rollout *v1alpha1.Rollout, desiredWeight i
 	if err != nil {
 		msg := fmt.Sprintf(GatewayAPIUpdateError, tcpRoute.GetName(), err)
 		r.LogCtx.Error(msg)
+		return pluginTypes.RpcError{
+			ErrorString: err.Error(),
+		}
 	}
 	return pluginTypes.RpcError{}
 }