Prep for review

.github/workflows/solidity.yml

@@ -59,8 +59,7 @@ jobs:
           echo "COMMIT=$COMMIT" | tee -a $GITHUB_ENV
       # Comment failure on PR when test fails on `pull_request`
       - name: Comment on failing run
-        #if: steps.solidity-test.outcome != 'success' && github.event_name == 'pull_request'
-        if: steps.solidity-test.outcome != 'success' && github.event_name != 'pull_request'
+        if: steps.solidity-test.outcome != 'success' && github.event_name == 'pull_request'
         uses: peter-evans/create-or-update-comment@v4
         with:
           issue-number: ${{ github.event.pull_request.number }}
@@ -70,14 +69,12 @@ jobs:
             ${{ env.WORKFLOW_URL }}
       # Open issue in `solidity-verifier` downstream when test fails on `merge_group`
       - uses: actions/checkout@v4
-        #if: steps.solidity-test.outcome != 'success' && (github.event_name != 'pull_request' || github.event.action == 'enqueued')
-        if: steps.solidity-test.outcome != 'success'
+        if: steps.solidity-test.outcome != 'success' && (github.event_name != 'pull_request' || github.event.action == 'enqueued')
         with:
           repository: lurk-lab/solidity-verifier
       # Have to check out Arecibo again to get the issue template
       - uses: actions/checkout@v4
-        #if: steps.solidity-test.outcome != 'success' && (github.event_name != 'pull_request' || github.event.action == 'enqueued')
-        if: steps.solidity-test.outcome != 'success'
+        if: steps.solidity-test.outcome != 'success' && (github.event_name != 'pull_request' || github.event.action == 'enqueued')
         with:
           repository: lurk-lab/arecibo
           path: ${{ github.workspace }}/template
@@ -86,8 +83,7 @@ jobs:
           sparse-checkout-cone-mode: false
       # Substitutes env vars for their values in `SOLIDITY_COMPAT_ISSUE.md`
       - uses: falnyr/replace-env-vars-action@master
-        #if: steps.solidity-test.outcome != 'success' && (github.event_name != 'pull_request' || github.event.action == 'enqueued')
-        if: steps.solidity-test.outcome != 'success'
+        if: steps.solidity-test.outcome != 'success' && (github.event_name != 'pull_request' || github.event.action == 'enqueued')
         env:
           WORKFLOW_URL: ${{ env.WORKFLOW_URL }}
           WORKFLOW_FILE: ${{ env.WORKFLOW_FILE }}
@@ -99,8 +95,7 @@ jobs:
       # Finds the last open issue in `solidity-verifier` matching given labels
       - name: Find the last open compatibility issue
         id: last-issue
-        #if: steps.solidity-test.outcome != 'success' && (github.event_name != 'pull_request' || github.event.action == 'enqueued')
-        if: steps.solidity-test.outcome != 'success'
+        if: steps.solidity-test.outcome != 'success' && (github.event_name != 'pull_request' || github.event.action == 'enqueued')
         uses: micalevisk/last-issue-action@v2
         with:
           repository: lurk-lab/solidity-verifier
@@ -112,8 +107,7 @@ jobs:
             automated issue
       # Update existing issue in `solidity-verifier` downstream or create new one
       - uses: peter-evans/create-issue-from-file@v5
-        #if: steps.solidity-test.outcome != 'success' && (github.event_name != 'pull_request' || github.event.action == 'enqueued')
-        if: steps.solidity-test.outcome != 'success'
+        if: steps.solidity-test.outcome != 'success' && (github.event_name != 'pull_request' || github.event.action == 'enqueued')
         with:
           token: ${{ secrets.REPO_TOKEN }}
           repository: lurk-lab/solidity-verifier

src/provider/tests/ipa_pc.rs

@@ -77,9 +77,7 @@ return keccak_transcript;
   // cargo test test_solidity_compatibility_ipa --release -- --ignored --nocapture > ipa.t.sol
   #[test]
   #[ignore]
-  #[allow(unreachable_code)]
   fn test_solidity_compatibility_ipa() {
-    panic!("Testing failure in CI");
     let num_vars = 2;
 
     // Secondary part of verification is IPA over Grumpkin