Skip to content

Commit

Permalink
chore: fix typos (#316)
Browse files Browse the repository at this point in the history
  • Loading branch information
samuelburnham authored Feb 11, 2024
1 parent af32a9a commit efaf628
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions src/gadgets/nonnative/bignat.rs
Original file line number Diff line number Diff line change
Expand Up @@ -494,7 +494,7 @@ impl<Scalar: PrimeField> BigNat<Scalar> {
})
}

/// Compute a `BigNat` contrained to be equal to `self * other % modulus`.
/// Compute a `BigNat` constrained to be equal to `self * other % modulus`.
pub fn mult_mod<CS: ConstraintSystem<Scalar>>(
&self,
mut cs: CS,
Expand Down Expand Up @@ -565,7 +565,7 @@ impl<Scalar: PrimeField> BigNat<Scalar> {
Ok((quotient, remainder))
}

/// Compute a `BigNat` contrained to be equal to `self * other % modulus`.
/// Compute a `BigNat` constrained to be equal to `self * other % modulus`.
pub fn red_mod<CS: ConstraintSystem<Scalar>>(
&self,
mut cs: CS,
Expand Down
4 changes: 2 additions & 2 deletions src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -650,14 +650,14 @@ where
let is_inputs_not_match = self.z0_primary != z0_primary || self.z0_secondary != z0_secondary;

// check if the (relaxed) R1CS instances have two public outputs
let is_instance_has_two_outpus = self.l_u_secondary.X.len() != 2
let is_instance_has_two_outputs = self.l_u_secondary.X.len() != 2
|| self.r_U_primary.X.len() != 2
|| self.r_U_secondary.X.len() != 2;

if is_num_steps_zero
|| is_num_steps_not_match
|| is_inputs_not_match
|| is_instance_has_two_outpus
|| is_instance_has_two_outputs
{
return Err(NovaError::ProofVerifyError);
}
Expand Down
2 changes: 1 addition & 1 deletion src/provider/non_hiding_kzg.rs
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,7 @@ where
}

/// Generate a commitment for a polynomial
/// Note that the scheme is not hidding
/// Note that the scheme is not hiding
pub fn commit(
prover_param: impl Borrow<KZGProverKey<E>>,
poly: &UVKZGPoly<E::Fr>,
Expand Down
2 changes: 1 addition & 1 deletion src/provider/non_hiding_zeromorph.rs
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ where
}

/// Generate a commitment for a polynomial
/// Note that the scheme is not hidding
/// Note that the scheme is not hiding
fn commit(
pp: impl Borrow<ZMProverKey<E>>,
poly: &MultilinearPolynomial<E::Fr>,
Expand Down

1 comment on commit efaf628

@github-actions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmarks

Table of Contents

Overview

This benchmark report shows the Arecibo GPU benchmarks.
NVIDIA L4
Intel(R) Xeon(R) CPU @ 2.20GHz
32 vCPUs
125 GB RAM
Workflow run: https://github.com/lurk-lab/arecibo/actions/runs/7864432895

Benchmark Results

RecursiveSNARK-NIVC-2

ref=af32a9a ref=efaf628
Prove-NumCons-6540 54.05 ms (✅ 1.00x) 53.79 ms (✅ 1.00x faster)
Verify-NumCons-6540 34.45 ms (✅ 1.00x) 34.52 ms (✅ 1.00x slower)
Prove-NumCons-1028888 350.08 ms (✅ 1.00x) 348.37 ms (✅ 1.00x faster)
Verify-NumCons-1028888 258.95 ms (✅ 1.00x) 265.80 ms (✅ 1.03x slower)

CompressedSNARK-NIVC-Commitments-2

ref=af32a9a ref=efaf628
Prove-NumCons-6540 14.38 s (✅ 1.00x) 14.41 s (✅ 1.00x slower)
Verify-NumCons-6540 79.28 ms (✅ 1.00x) 80.28 ms (✅ 1.01x slower)
Prove-NumCons-1028888 113.20 s (✅ 1.00x) 112.38 s (✅ 1.01x faster)
Verify-NumCons-1028888 779.31 ms (✅ 1.00x) 779.65 ms (✅ 1.00x slower)

Made with criterion-table

Please sign in to comment.