Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organize public param creation with assorted structs #288

Draft
wants to merge 5 commits into
base: dev
Choose a base branch
from

Commits on Jan 29, 2024

  1. refactor: Refactor codebase to use Arc for commitment keys

    - Major changes in the handling of the Commitment Key object across several files, moving from direct references to using the Arc (Atomic Reference Counting) mechanism for improved thread-safety and efficient sharing of data.
    - Removed the `Abomonation` trait from several structures, such as `ProverKey` and `VerifierKey`.
    - Introduced the `SimpleDigestible` trait to VerifierKey in several files, allowing them to be converted into a digestible form for hashing or storage.
    - Numerous updates in test cases and instances to reflect the shift from direct Commitment Key references to Arc.
    - Refactoring of the `setup` and `prove` methods in multiple files to handle the Arc type for Commitment Key.
    - Removal of several `abomonate_with` and `abomonation_skip` attribute annotations.
    - Enhancement of error details in multiple `assert` statements.
    - Added "rc" feature to the serde dependency in the Cargo.toml file.
    - Made comments on minimizing unnecessary data copies and keeping `setup` methods inexpensive.
    huitseeker committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    23faed5 View commit details
    Browse the repository at this point in the history
  2. refactor: Serialization with Abomonation

    - Extended functionality in `lib.rs` with new `PublicParams` structure, efficient abomonationwith `FlatPublicParams`,
    - Updated `mod.rs` for conditional feature `abomonate`, added `AuxParams` struct, and implemented conversions between `AuxParams` and `FlatAuxParams`.
    - demoed the new use of Abomonation in the minroot example
    huitseeker committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    78741eb View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2024

  1. refactor: clean up superfluous Abomonation bounds

    - Removed Abomonation dependency from several files.
    huitseeker committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    9ba8a37 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3d5e341 View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2024

  1. organize structs

    Hanting Zhang committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    b480ad2 View commit details
    Browse the repository at this point in the history