Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port paranova. #86

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from
Draft

Port paranova. #86

wants to merge 1 commit into from

Conversation

porcuquine
Copy link
Contributor

@porcuquine porcuquine commented Oct 28, 2023

This is a port of the much-appreciated ParaNova prototype from
privacy-scaling-explorations/Nova#11

You can learn more about Paranova from https://zkresear.ch/t/parallelizing-nova-visualizations-and-mental-models-behind-paranova/198 or https://zuzalu.streameth.org/session/169

The idea is to use the general shape and scaffolding to iterate on in arecibo. Since those plans are beyond the scope of this port, I won't elaborate here.

For this to be accepted, we should primarily feel confident that it doesn't interfere with or harm existing Nova/SuperNova work. Over time, either before or after merging this, we can work on refactoring so Nova is least affected and (to the extent it must be) intelligently modified to best support the work here while staying true to its nature.

Note that Nova and SuperNova tests still pass and circuit constraint count has not increased. This work intends not to affect the substance of existing circuits or proving mechanisms.

h/t @oskarth @chiro-hiro @aleph-v @nalinbhardwaj @CPerezz

@porcuquine porcuquine marked this pull request as draft October 28, 2023 00:53
@porcuquine porcuquine force-pushed the paranova-import branch 2 times, most recently from 2e21893 to dad6a67 Compare October 28, 2023 01:19
@porcuquine porcuquine marked this pull request as ready for review October 28, 2023 01:47
@porcuquine porcuquine marked this pull request as draft October 31, 2023 02:24
@adr1anh adr1anh self-assigned this Nov 16, 2023
@aleph-v
Copy link

aleph-v commented Nov 28, 2023

Hey, umm so I have 0 context on this but I was tagged here. If you're importing the code from the prototypes we worked in the Vietnam 0xParc residency I would advise some caution as I wrote a large portion of it and I know for a fact it has soundness bugs.

@porcuquine
Copy link
Contributor Author

Thanks for your diligence. We're going to include the important incremental work by @nikkolasg (https://github.com/nikkolasg/Nova/blob/mapreduce/examples/merkle_tree.rs) as described here: https://lagrangelabs.notion.site/Nova-from-IVC-to-general-PCD-for-zkMapReduce-d04afec2d70c47db9dfb67e84d0d796e. This was an exercise in bringing your prototype up-to-date, and we are aware that it has issues.

@Lev-Stambler
Copy link

I would love to help this get up and running!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants