more syntax tests fixes

proptest-regressions/parser/syntax.txt

@@ -0,0 +1,7 @@
+# Seeds for failure cases proptest has generated in the past. It is
+# automatically read and these particular cases re-run before any
+# novel cases are generated.
+#
+# It is recommended to check this file in to source control so that
+# everyone who runs the test benefits from these saved cases.
+cc 72dda53aa591d94f5466c82b7f57c179c5b7e39a1fa3d88058bbe1fc5b05a501 # shrinks to x = Quote(No, List(No, [Path(No, ["."], false)]))

src/parser/syntax.rs

@@ -385,7 +385,11 @@ pub mod tests {
         assert!(test(parse_path(), "..", Some(sym_path!([""]))));
         assert!(test(parse_path(), "foo", Some(rel_path!(["foo"]))));
         assert!(test(parse_path(), "|foo|", Some(rel_path!(["foo"]))));
-        assert!(test(parse_path(), "|Hi, bye|", Some(rel_path!(["Hi, bye"]))));
+        assert!(test(
+            parse_path(),
+            "|Hi, bye|",
+            Some(rel_path!(["Hi, bye"]))
+        ));
         assert!(test(
             parse_path(),
             "|foo|.|bar|",
@@ -427,7 +431,11 @@ pub mod tests {
             ".foo\\u{00}.bar\\u{00}",
             Some(sym_path!(["foo\u{00}", "bar\u{00}"]))
         ));
-        assert!(test(parse_path(), ".foo\\.bar", Some(sym_path!(["foo.bar"]))));
+        assert!(test(
+            parse_path(),
+            ".foo\\.bar",
+            Some(sym_path!(["foo.bar"]))
+        ));
         assert!(test(parse_path(), "~(asdf )", Some(sym_path!(["asdf"]))));
         assert!(test(parse_path(), "~( asdf )", Some(sym_path!(["asdf"]))));
         assert!(test(parse_path(), "~( asdf)", Some(sym_path!(["asdf"]))));
@@ -508,7 +516,10 @@ pub mod tests {
         assert!(test(
             parse_syntax(),
             "(.foo.bar .foo.bar)",
-            Some(list!([sym_path!(["foo", "bar"]), sym_path!(["foo", "bar"])])),
+            Some(list!([
+                sym_path!(["foo", "bar"]),
+                sym_path!(["foo", "bar"])
+            ])),
         ));
         assert!(test(
             parse_syntax(),
@@ -523,7 +534,10 @@ pub mod tests {
         assert!(test(
             parse_syntax(),
             "(a b . c)",
-            Some(list!([rel_path!(["a"]), rel_path!(["b"])], rel_path!(["c"]))),
+            Some(list!(
+                [rel_path!(["a"]), rel_path!(["b"])],
+                rel_path!(["c"])
+            )),
         ));
         assert!(test(
             parse_syntax(),
@@ -536,7 +550,11 @@ pub mod tests {
         assert!(test(
             parse_syntax(),
             "(a b c)",
-            Some(list!([rel_path!(["a"]), rel_path!(["b"]), rel_path!(["c"])])),
+            Some(list!([
+                rel_path!(["a"]),
+                rel_path!(["b"]),
+                rel_path!(["c"])
+            ])),
         ));
         assert!(test(
             parse_syntax(),
@@ -547,7 +565,11 @@ pub mod tests {
         assert!(test(
             parse_syntax(),
             "(a. b. c.)",
-            Some(list!([rel_path!(["a"]), rel_path!(["b"]), rel_path!(["c"])])),
+            Some(list!([
+                rel_path!(["a"]),
+                rel_path!(["b"]),
+                rel_path!(["c"])
+            ])),
         ));
         assert!(test(
             parse_syntax(),
@@ -750,8 +772,8 @@ pub mod tests {
                 "{}",
                 list!(
                     Scalar,
-                    [Syntax::Quote(Pos::No, Box::new(rel_path!([""])))],
-                    sym_path!(["a"])
+                    [Syntax::Quote(Pos::No, Box::new(sym_path!([""])))],
+                    rel_path!(["a"])
                 )
             )
         );

src/symbol.rs

@@ -1,7 +1,6 @@
 use std::fmt;
 
 use anyhow::{bail, Result};
-use itertools::Itertools;
 
 use crate::parser::LURK_WHITESPACE;
 #[cfg(not(target_arch = "wasm32"))]
@@ -281,19 +280,23 @@ impl Symbol {
                 res.push(c)
             }
         }
-        if res.is_empty() {
-            "||".into()
-        } else if has_whitespace || Self::start_needs_escaping(&res) {
+        if has_whitespace || Self::start_needs_escaping(&res) {
             format!("|{res}|")
         } else {
             res
         }
     }
 
     pub fn format_path(path: &[String]) -> String {
-        path.iter()
-            .map(|s| Self::format_path_component(s))
-            .join(".")
+        let mut res = String::new();
+        let mut iter = path.iter().peekable();
+        while let Some(next) = iter.next() {
+            res.push_str(&Self::format_path_component(next));
+            if iter.peek().is_some() || next.is_empty() {
+                res.push('.');
+            }
+        }
+        res
     }
 
     pub fn format(&self) -> String {