Skip to content

Commit

Permalink
ci: switch to dtolnay/rust-toolchain (#1000)
Browse files Browse the repository at this point in the history
  • Loading branch information
huitseeker authored Dec 22, 2023
1 parent 0a4960a commit 483a7b8
Show file tree
Hide file tree
Showing 9 changed files with 20 additions and 15 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/bench-deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
steps:
# Install deps
- uses: actions/checkout@v4
- uses: actions-rs/toolchain@v1
- uses: dtolnay/rust-toolchain@stable
- uses: Swatinem/rust-cache@v2
- uses: taiki-e/install-action@v2
with:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/bench-pr-comment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:
# Install dependencies
- name: Install dependencies
run: sudo apt-get install -y pkg-config libssl-dev
- uses: actions-rs/toolchain@v1
- uses: dtolnay/rust-toolchain@stable
- uses: Swatinem/rust-cache@v2
- name: Load env vars
run: |
Expand Down Expand Up @@ -84,7 +84,7 @@ jobs:
# This must also be compatible with the GPU architecture, see above link
- run: nvcc --version
# Install dependencies
- uses: actions-rs/toolchain@v1
- uses: dtolnay/rust-toolchain@stable
- uses: Swatinem/rust-cache@v2
- name: Set output type
run: echo "LURK_BENCH_OUTPUT=pr-comment" >> $GITHUB_ENV
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ jobs:
submodules: recursive
- name: Install dependencies
run: sudo apt-get install -y pkg-config libssl-dev
- uses: actions-rs/toolchain@v1
- uses: dtolnay/rust-toolchain@stable
- uses: taiki-e/install-action@nextest
- uses: Swatinem/rust-cache@v2
- name: Linux Tests
Expand All @@ -64,7 +64,7 @@ jobs:
RUSTFLAGS: -D warnings
steps:
- uses: actions/checkout@v4
- uses: actions-rs/toolchain@v1
- uses: dtolnay/rust-toolchain@stable
- uses: taiki-e/install-action@nextest
- uses: Swatinem/rust-cache@v2
- run: rustup target add wasm32-unknown-unknown
Expand All @@ -83,7 +83,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions-rs/toolchain@v1
- uses: dtolnay/rust-toolchain@stable
with:
components: rustfmt, clippy
- uses: Swatinem/rust-cache@v2
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/gpu-bench-workflow-dispatch.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
- run: nvcc --version
- uses: actions/checkout@v4
# Install dependencies
- uses: actions-rs/toolchain@v1
- uses: dtolnay/rust-toolchain@stable
- uses: Swatinem/rust-cache@v2
- uses: taiki-e/install-action@v2
with:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/gpu-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ jobs:
- uses: actions/checkout@v4
with:
submodules: recursive
- uses: actions-rs/toolchain@v1
- uses: dtolnay/rust-toolchain@stable
- uses: taiki-e/install-action@nextest
- uses: Swatinem/rust-cache@v2
# Check we have access to the machine's Nvidia drivers
Expand Down Expand Up @@ -79,7 +79,7 @@ jobs:
- uses: actions/checkout@v4
with:
submodules: recursive
- uses: actions-rs/toolchain@v1
- uses: dtolnay/rust-toolchain@stable
- uses: taiki-e/install-action@nextest
- uses: Swatinem/rust-cache@v2
# Check we have access to the machine's Nvidia drivers
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/merge-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
- uses: actions/checkout@v4
with:
submodules: recursive
- uses: actions-rs/toolchain@v1
- uses: dtolnay/rust-toolchain@stable
- uses: taiki-e/install-action@nextest
- uses: Swatinem/rust-cache@v2
- name: Linux Tests
Expand All @@ -37,7 +37,7 @@ jobs:
- uses: actions/checkout@v4
with:
submodules: recursive
- uses: actions-rs/toolchain@v1
- uses: dtolnay/rust-toolchain@stable
- uses: taiki-e/install-action@nextest
- uses: Swatinem/rust-cache@v2
- name: Linux Tests
Expand All @@ -54,7 +54,7 @@ jobs:
- uses: actions/checkout@v4
with:
submodules: recursive
- uses: actions-rs/toolchain@v1
- uses: dtolnay/rust-toolchain@stable
- uses: taiki-e/install-action@nextest
- uses: Swatinem/rust-cache@v2
- name: Linux Tests
Expand All @@ -80,7 +80,7 @@ jobs:
- run: nvcc --version
- uses: actions/checkout@v4
# Install dependencies
- uses: actions-rs/toolchain@v1
- uses: dtolnay/rust-toolchain@stable
- uses: Swatinem/rust-cache@v2
- uses: taiki-e/install-action@v2
with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/nightly.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:
submodules: recursive
- name: Install dependencies
run: sudo apt-get install -y pkg-config libssl-dev
- uses: actions-rs/toolchain@v1
- uses: dtolnay/rust-toolchain@stable
- uses: taiki-e/install-action@nextest
- uses: Swatinem/rust-cache@v2
- name: Linux Tests
Expand Down
1 change: 0 additions & 1 deletion rust-toolchain

This file was deleted.

6 changes: 6 additions & 0 deletions rust-toolchain.toml
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
[toolchain]
# The default profile includes rustc, rust-std, cargo, rust-docs, rustfmt and clippy.
profile = "default"
channel = "1.73"
targets = [ "wasm32-unknown-unknown" ]

2 comments on commit 483a7b8

@github-actions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmarks

Table of Contents

Overview

This benchmark report shows the Fibonacci GPU benchmark.
NVIDIA L4
Intel(R) Xeon(R) CPU @ 2.20GHz
125.78 GB RAM
Workflow run: https://github.com/lurk-lab/lurk-rs/actions/runs/7301939472

Benchmark Results

LEM Fibonacci Prove - rc = 100

fib-ref=0a4960a846be8d5a6fbaa762eb5353a13fae1374 fib-ref=483a7b8876ee3b05e5cd459e19ea2cbfa6c0a3bb
num-100 2.36 s (✅ 1.00x) 2.37 s (✅ 1.00x slower)
num-200 4.63 s (✅ 1.00x) 4.64 s (✅ 1.00x slower)

LEM Fibonacci Prove - rc = 600

fib-ref=0a4960a846be8d5a6fbaa762eb5353a13fae1374 fib-ref=483a7b8876ee3b05e5cd459e19ea2cbfa6c0a3bb
num-100 1.99 s (✅ 1.00x) 1.98 s (✅ 1.00x faster)
num-200 4.50 s (✅ 1.00x) 4.49 s (✅ 1.00x faster)

Made with criterion-table

@github-actions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmarks

Table of Contents

Overview

This benchmark report shows the Fibonacci GPU benchmark.
NVIDIA L4
Intel(R) Xeon(R) CPU @ 2.20GHz
125.78 GB RAM

Benchmark Results

LEM Fibonacci Prove - rc = 100

fib-ref=483a7b8876ee3b05e5cd459e19ea2cbfa6c0a3bb
num-100 2.36 s (✅ 1.00x)
num-200 4.63 s (✅ 1.00x)

LEM Fibonacci Prove - rc = 600

fib-ref=483a7b8876ee3b05e5cd459e19ea2cbfa6c0a3bb
num-100 1.98 s (✅ 1.00x)
num-200 4.48 s (✅ 1.00x)

Made with criterion-table

Please sign in to comment.