Skip to content

Commit

Permalink
chore: Use Bn256/Grumpkin curves by default in lem/store.rs
Browse files Browse the repository at this point in the history
  • Loading branch information
storojs72 committed Jan 12, 2024
1 parent 7e1275a commit c8373c1
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 5 deletions.
2 changes: 1 addition & 1 deletion src/eval/lang.rs
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ pub(crate) mod test {
use crate::sym;

use super::*;
use halo2curves::bn256::Fr as Fr;
use halo2curves::bn256::Fr;

#[test]
fn lang() {
Expand Down
2 changes: 2 additions & 0 deletions src/lem/circuit.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1680,6 +1680,8 @@ impl Func {
let bit_decomp_cost = match F::FIELD {
LanguageField::Pallas => 298,
LanguageField::Vesta => 301,
// TODO: investigate how to properly compute this number, as it was obtained empirically
LanguageField::BN256 => 354,
_ => todo!(),
};

Expand Down
6 changes: 3 additions & 3 deletions src/lem/eval.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1726,7 +1726,7 @@ mod tests {
};
use bellpepper_core::{test_cs::TestConstraintSystem, Comparable};
use expect_test::{expect, Expect};
use pasta_curves::pallas::Scalar as Fr;
use halo2curves::bn256::Fr;

#[test]
fn test_counts() {
Expand All @@ -1745,8 +1745,8 @@ mod tests {
expect_eq(func.slots_count.commitment, expect!["1"]);
expect_eq(func.slots_count.bit_decomp, expect!["3"]);
expect_eq(cs.num_inputs(), expect!["1"]);
expect_eq(cs.aux().len(), expect!["8927"]);
expect_eq(cs.num_constraints(), expect!["10857"]);
expect_eq(cs.aux().len(), expect!["9095"]);
expect_eq(cs.num_constraints(), expect!["11025"]);
assert_eq!(func.num_constraints(&store), cs.num_constraints());
}
}
2 changes: 1 addition & 1 deletion src/lem/store.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1346,7 +1346,7 @@ impl Ptr {
#[cfg(test)]
mod tests {
use ff::Field;
use pasta_curves::pallas::Scalar as Fr;
use halo2curves::bn256::Fr;
use proptest::prelude::*;

use crate::{
Expand Down

0 comments on commit c8373c1

Please sign in to comment.