Skip to content

Commit

Permalink
fix: adapt to arecibo changes (#1019)
Browse files Browse the repository at this point in the history
* fix: adapt to arecibo changes

* chore: move the arecibo pointer back to dev
  • Loading branch information
huitseeker authored Jan 5, 2024
1 parent bc13609 commit f1c5064
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 11 deletions.
4 changes: 2 additions & 2 deletions src/cli/lurk_proof.rs
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
use ::nova::{
supernova::NonUniformCircuit,
traits::{circuit_supernova::StepCircuit as SuperStepCircuit, Engine},
supernova::{NonUniformCircuit, StepCircuit as SuperStepCircuit},
traits::Engine,
};
use abomonation::Abomonation;
use anyhow::{bail, Result};
Expand Down
4 changes: 1 addition & 3 deletions src/lem/multiframe.rs
Original file line number Diff line number Diff line change
Expand Up @@ -871,9 +871,7 @@ impl<'a, F: LurkField, C: Coprocessor<F>> nova::traits::circuit::StepCircuit<F>
}
}

impl<'a, F: LurkField, C: Coprocessor<F>> nova::traits::circuit_supernova::StepCircuit<F>
for MultiFrame<'a, F, C>
{
impl<'a, F: LurkField, C: Coprocessor<F>> nova::supernova::StepCircuit<F> for MultiFrame<'a, F, C> {
fn arity(&self) -> usize {
2 * self.lurk_step.input_params.len()
}
Expand Down
4 changes: 2 additions & 2 deletions src/proof/nova.rs
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ use nova::{
snark::RelaxedR1CSSNARKTrait,
Engine,
},
CircuitShape, CompressedSNARK, ProverKey, RecursiveSNARK, VerifierKey,
CompressedSNARK, ProverKey, R1CSWithArity, RecursiveSNARK, VerifierKey,
};
use pasta_curves::pallas;
use serde::{Deserialize, Serialize};
Expand Down Expand Up @@ -102,7 +102,7 @@ pub type C1LEM<'a, F, C> = crate::lem::multiframe::MultiFrame<'a, F, C>;
pub type C2<F> = TrivialCircuit<<E2<F> as Engine>::Scalar>;

/// Type alias for Nova Circuit Parameters with the curve cycle types defined above.
pub type NovaCircuitShape<F> = CircuitShape<E1<F>>;
pub type NovaCircuitShape<F> = R1CSWithArity<E1<F>>;

/// Type alias for Nova Public Parameters with the curve cycle types defined above.
pub type NovaPublicParams<F, C1> = nova::PublicParams<E1<F>, E2<F>, C1, C2<F>>;
Expand Down
2 changes: 1 addition & 1 deletion src/proof/supernova.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@ use nova::{
error::SuperNovaError,
snark::{CompressedSNARK, ProverKey, VerifierKey},
AuxParams, CircuitDigests, NonUniformCircuit, RecursiveSNARK,
StepCircuit as SuperStepCircuit, TrivialSecondaryCircuit,
},
traits::{
circuit_supernova::{StepCircuit as SuperStepCircuit, TrivialSecondaryCircuit},
snark::{BatchedRelaxedR1CSSNARKTrait, RelaxedR1CSSNARKTrait},
Engine,
},
Expand Down
4 changes: 2 additions & 2 deletions src/public_parameters/instance.rs
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,8 @@ use std::{

use ::nova::{
constants::NUM_HASH_BITS,
supernova::NonUniformCircuit,
traits::{circuit_supernova::StepCircuit as SuperStepCircuit, Engine},
supernova::{NonUniformCircuit, StepCircuit as SuperStepCircuit},
traits::Engine,
};
use abomonation::Abomonation;
use camino::Utf8Path;
Expand Down
2 changes: 1 addition & 1 deletion src/public_parameters/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ where

/// Attempts to extract abomonated public parameters.
use ::nova::supernova::NonUniformCircuit;
use ::nova::traits::circuit_supernova::StepCircuit as SuperStepCircuit;
use ::nova::supernova::StepCircuit as SuperStepCircuit;
use supernova::C2;
pub fn supernova_public_params<
'a,
Expand Down

1 comment on commit f1c5064

@github-actions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmarks

Table of Contents

Overview

This benchmark report shows the Fibonacci GPU benchmark.
NVIDIA L4
Intel(R) Xeon(R) CPU @ 2.20GHz
125.78 GB RAM
Workflow run: https://github.com/lurk-lab/lurk-rs/actions/runs/7423797516

Benchmark Results

LEM Fibonacci Prove - rc = 100

fib-ref=bc136099c58c1402510b949b29768d604642405b fib-ref=f1c5064774e419086bc09b8c8148f6fdd03ff0e8
num-100 2.36 s (✅ 1.00x) 2.37 s (✅ 1.00x slower)
num-200 4.64 s (✅ 1.00x) 4.65 s (✅ 1.00x slower)

LEM Fibonacci Prove - rc = 600

fib-ref=bc136099c58c1402510b949b29768d604642405b fib-ref=f1c5064774e419086bc09b8c8148f6fdd03ff0e8
num-100 1.99 s (✅ 1.00x) 1.99 s (✅ 1.00x faster)
num-200 4.50 s (✅ 1.00x) 4.49 s (✅ 1.00x faster)

Made with criterion-table

Please sign in to comment.