Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Towards Lurk alpha cleanup + Lurk Beta #804

Closed
10 tasks done
huitseeker opened this issue Oct 26, 2023 · 1 comment
Closed
10 tasks done

Towards Lurk alpha cleanup + Lurk Beta #804

huitseeker opened this issue Oct 26, 2023 · 1 comment
Labels
epic Umbrella issue

Comments

@huitseeker
Copy link
Member

huitseeker commented Oct 26, 2023 •
edited
Loading

@huitseeker huitseeker added the epic Umbrella issue label Oct 26, 2023
@huitseeker
Copy link
Member Author

huitseeker commented Oct 31, 2023 •
edited
Loading

In order to make the war room effective, we need to organize ourselves to organize tasks in parallel as much as possible. We can remove Alpha functionality in the reverse order that LEM functionality was introduced. The following seems to be the sensible order, with some items that could be addressed in parallel (e.g. benchmarks and examples):

Removing the Alpha Store and Ptr types can be seen as an ultimate clean up milestone

@arthurpaulino arthurpaulino mentioned this issue Oct 31, 2023
Closed
@huitseeker huitseeker mentioned this issue Nov 1, 2023
Closed
huitseeker added a commit to huitseeker/lurk-rs that referenced this issue Nov 1, 2023
@huitseeker
chore: remove dead code from multiple modules
0b7b8d1 
- Removed redundant and unused functions across multiple files including `hash_witness.rs`, `z_data/z_store.rs`, `eval/mod.rs`, and `symbol.rs`.

Remaining unused items are in the following categories:
- in a module we don't want to touch today (argumentcomputer#804), and where removal needs some thought, e.g. `parse_code`, `parse_space`, `parse_line_comment`, `assert_all_paths_taken`, `construct`, `construct_strcons`,
- small utilities which removal wouldn't be significant, e.g. `is_evaluation`, `is_root_symbol`, `push_tag`, `push_symbol`, `push_default`, `to_z_expr`, `is_coprocessor`
- related to underused functionality we know we'll want to extend the use of:
    - supernova (`supernova_circuit_params`, `supernova_aux_params`, `supernova_public_params`),
    - opaque pointers (`intern_maybe_opaque_fun`, `intern_maybe_opaque_sym`, `hidden`, `get_opaque_ptr`, `new_opaque_pr`, ...)
    - public parameter caching (`circuit_cache_key`, `with_public_params`)
@huitseeker huitseeker mentioned this issue Nov 1, 2023
Merged
huitseeker added a commit to huitseeker/lurk-rs that referenced this issue Nov 1, 2023
@huitseeker
chore: remove dead code from multiple modules
f82a5e5 
- Removed redundant and unused functions across multiple files including `hash_witness.rs`, `z_data/z_store.rs`, `eval/mod.rs`, and `symbol.rs`.

Remaining unused items are in the following categories:
- in a module we don't want to touch today (argumentcomputer#804), and where removal needs some thought, e.g. `parse_code`, `parse_space`, `parse_line_comment`, `assert_all_paths_taken`, `construct`, `construct_strcons`,
- small utilities which removal wouldn't be significant, e.g. `is_evaluation`, `is_root_symbol`, `push_tag`, `push_symbol`, `push_default`, `to_z_expr`, `is_coprocessor`
- related to underused functionality we know we'll want to extend the use of:
    - supernova (`supernova_circuit_params`, `supernova_aux_params`, `supernova_public_params`),
    - opaque pointers (`intern_maybe_opaque_fun`, `intern_maybe_opaque_sym`, `hidden`, `get_opaque_ptr`, `new_opaque_pr`, ...)
    - public parameter caching (`circuit_cache_key`, `with_public_params`)
github-merge-queue bot pushed a commit that referenced this issue Nov 1, 2023
@huitseeker
chore: remove dead code from multiple modules (#828)
7f6069e 
- Removed redundant and unused functions across multiple files including `hash_witness.rs`, `z_data/z_store.rs`, `eval/mod.rs`, and `symbol.rs`.

Remaining unused items are in the following categories:
- in a module we don't want to touch today (#804), and where removal needs some thought, e.g. `parse_code`, `parse_space`, `parse_line_comment`, `assert_all_paths_taken`, `construct`, `construct_strcons`,
- small utilities which removal wouldn't be significant, e.g. `is_evaluation`, `is_root_symbol`, `push_tag`, `push_symbol`, `push_default`, `to_z_expr`, `is_coprocessor`
- related to underused functionality we know we'll want to extend the use of:
    - supernova (`supernova_circuit_params`, `supernova_aux_params`, `supernova_public_params`),
    - opaque pointers (`intern_maybe_opaque_fun`, `intern_maybe_opaque_sym`, `hidden`, `get_opaque_ptr`, `new_opaque_pr`, ...)
    - public parameter caching (`circuit_cache_key`, `with_public_params`)
This was referenced Nov 1, 2023
Closed
Closed
@huitseeker huitseeker mentioned this issue Nov 13, 2023
Merged
@arthurpaulino arthurpaulino mentioned this issue Nov 14, 2023
Merged
@huitseeker huitseeker mentioned this issue Dec 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
epic Umbrella issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@huitseeker