chore: remove dead code from multiple modules (easy) #828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed redundant and unused functions across multiple files including `hash_witness.rs`, `z_data/z_store.rs`, `eval/mod.rs`, and `symbol.rs`. Remaining unused items are in the following categories: - in a module we don't want to touch today (argumentcomputer#804), and where removal needs some thought, e.g. `parse_code`, `parse_space`, `parse_line_comment`, `assert_all_paths_taken`, `construct`, `construct_strcons`, - small utilities which removal wouldn't be significant, e.g. `is_evaluation`, `is_root_symbol`, `push_tag`, `push_symbol`, `push_default`, `to_z_expr`, `is_coprocessor` - related to underused functionality we know we'll want to extend the use of: - supernova (`supernova_circuit_params`, `supernova_aux_params`, `supernova_public_params`), - opaque pointers (`intern_maybe_opaque_fun`, `intern_maybe_opaque_sym`, `hidden`, `get_opaque_ptr`, `new_opaque_pr`, ...) - public parameter caching (`circuit_cache_key`, `with_public_params`)
huitseeker
force-pushed
the
delete_dead_code
branch
from
0b7b8d1
to
f82a5e5
Compare
huitseeker
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hash_witness.rs,z_data/z_store.rs,eval/mod.rs, andsymbol.rs.Remaining unused items are in the following categories:
parse_code,parse_space,parse_line_comment,assert_all_paths_taken,construct,construct_strcons,is_evaluation,is_root_symbol,push_tag,push_symbol,push_default,to_z_expr,is_coprocessorsupernova_circuit_params,supernova_aux_params,supernova_public_params),intern_maybe_opaque_fun,intern_maybe_opaque_sym,hidden,get_opaque_ptr,new_opaque_pr, ...)circuit_cache_key,with_public_params)Closes #214