Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request review from lurk-eval for changes in src/lem/eval.rs #1024

Merged
merged 1 commit into from
Jan 5, 2024
Merged

Request review from lurk-eval for changes in src/lem/eval.rs #1024

merged 1 commit into from
Jan 5, 2024

Conversation

arthurpaulino
Copy link
Member

@arthurpaulino arthurpaulino commented Jan 5, 2024 •
edited
Loading

This PR needs the lurk-lem team to be renamed to lurk-eval. Its description should be "Review approval for lem/eval.rs"

@arthurpaulino arthurpaulino requested a review from a team as a code owner January 5, 2024 18:37
@arthurpaulino arthurpaulino added the help wanted Extra attention is needed label Jan 5, 2024
huitseeker
huitseeker reviewed Jan 5, 2024
View reviewed changes
Copy link
Member

@huitseeker huitseeker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with this, but renaming a team amounts to a delete + re-creation which is tedious. Can't we just reuse lurk-lem?

@arthurpaulino
Copy link
Member Author

Sure, if we can't edit a team as I thought, I'll just reuse lurk-lem. The description is a bit off but that will do for the time being

@huitseeker
Copy link
Member

I'll be happy to edit the description, which is not subject to the same rules.

@arthurpaulino arthurpaulino added this pull request to the merge queue Jan 5, 2024
github-actions bot pushed a commit that referenced this pull request Jan 5, 2024
@arthurpaulino @github-actions
[automated] GPU Benchmark from PR #1024
f47820d
Merged via the queue into main with commit 753bf71 Jan 5, 2024
12 checks passed
@arthurpaulino arthurpaulino deleted the lurk-eval-team branch January 5, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huitseeker huitseeker huitseeker approved these changes

Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arthurpaulino @huitseeker