Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Modify Neptune package features in Cargo.toml #1100

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

huitseeker
Copy link
Member

  • Disabled default features for Neptune package to curb unnecessary functionalities

Moves our dependency graph for blst from

blst v0.3.11
├── blstrs v0.7.1 (https://github.com/lurk-lab/blstrs.git?branch=dev#ea97fc1a)
│   └── neptune v13.0.0 (https://github.com/lurk-lab/neptune?branch=dev#9105c4fd)
│       ├── arecibo v0.2.0 (https://github.com/lurk-lab/arecibo?branch=dev#7a5d7bf0)
│       │   └── lurk v0.3.1 (/Users/huitseeker/tmp/lurk-rs)
│       │       [dev-dependencies]
│       │       └── lurk-macros v0.2.0 (proc-macro) (/Users/huitseeker/tmp/lurk-rs/lurk-macros)
│       │           └── lurk v0.3.1 (/Users/huitseeker/tmp/lurk-rs) (*)
│       └── lurk v0.3.1 (/Users/huitseeker/tmp/lurk-rs) (*)
│   [build-dependencies]
│   └── neptune v13.0.0 (https://github.com/lurk-lab/neptune?branch=dev#9105c4fd) (*)
└── grumpkin-msm v0.1.0 (https://github.com/lurk-lab/grumpkin-msm?branch=dev#29af3cd2)
    └── arecibo v0.2.0 (https://github.com/lurk-lab/arecibo?branch=dev#7a5d7bf0) (*)

To:

blst v0.3.11
├── blstrs v0.7.1 (https://github.com/lurk-lab/blstrs.git?branch=dev#ea97fc1a)
│   [build-dependencies]
│   └── neptune v13.0.0 (https://github.com/lurk-lab/neptune?branch=dev#9105c4fd)
│       ├── arecibo v0.2.0 (https://github.com/lurk-lab/arecibo?branch=dev#7a5d7bf0)
│       │   └── lurk v0.3.1 (/Users/huitseeker/tmp/lurk-rs)
│       │       [dev-dependencies]
│       │       └── lurk-macros v0.2.0 (proc-macro) (/Users/huitseeker/tmp/lurk-rs/lurk-macros)
│       │           └── lurk v0.3.1 (/Users/huitseeker/tmp/lurk-rs) (*)
│       └── lurk v0.3.1 (/Users/huitseeker/tmp/lurk-rs) (*)
└── grumpkin-msm v0.1.0 (https://github.com/lurk-lab/grumpkin-msm?branch=dev#29af3cd2)
    └── arecibo v0.2.0 (https://github.com/lurk-lab/arecibo?branch=dev#7a5d7bf0) (*)

IOW, neptune doesn't load blst(rs) unless explicitly told to. (It is already told to load pasta)

- Disabled default features for Neptune package to curb unnecessary functionalities
@huitseeker huitseeker requested a review from a team as a code owner February 7, 2024 16:43
@huitseeker huitseeker added this pull request to the merge queue Feb 7, 2024
Merged via the queue into argumentcomputer:main with commit 5fc5679 Feb 7, 2024
11 checks passed
@huitseeker huitseeker deleted the optionalize-blstrs branch February 7, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants