-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: forget cached MultiFrame
witnesses after they're used
#1103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
!gpu-benchmark |
Benchmark for b694c16Click to view benchmark
|
porcuquine
previously approved these changes
Feb 8, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Feb 8, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Feb 8, 2024
samuelburnham
previously approved these changes
Feb 9, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Feb 9, 2024
huitseeker
previously approved these changes
Feb 9, 2024
arthurpaulino
dismissed stale reviews from huitseeker and samuelburnham
via
February 9, 2024 15:16
264d50a
arthurpaulino
force-pushed
the
ap/forgotten-witnesses
branch
from
February 9, 2024 15:16
ed3c330
to
264d50a
Compare
arthurpaulino
force-pushed
the
ap/forgotten-witnesses
branch
from
February 9, 2024 16:49
264d50a
to
6c3ec5e
Compare
samuelburnham
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following profiles are from calling
lurk
with--rc 100
and--limit 10000
and then proving the following (infinite, but capped) computation:Before:
After:
Note: the memory peak wasn't affected on my weak machine. But if the computation is long enough (so it takes longer to generate the witnesses for all multiframes) and there is a GPU available (so each proving step is faster), used witnesses from earlier multiframes will start being cleared out before new witnesses from later frames are created.