Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: forget cached MultiFrame witnesses after they're used #1103

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

arthurpaulino
Copy link
Member

@arthurpaulino arthurpaulino commented Feb 8, 2024

The following profiles are from calling lurk with --rc 100 and --limit 10000 and then proving the following (infinite, but capped) computation:

(letrec ((loop (lambda () (loop)))) (loop))

Before:
Captura de tela de 2024-02-08 10-01-40

After:
Captura de tela de 2024-02-08 09-51-35

Note: the memory peak wasn't affected on my weak machine. But if the computation is long enough (so it takes longer to generate the witnesses for all multiframes) and there is a GPU available (so each proving step is faster), used witnesses from earlier multiframes will start being cleared out before new witnesses from later frames are created.

@arthurpaulino arthurpaulino requested a review from a team as a code owner February 8, 2024 13:10
@arthurpaulino
Copy link
Member Author

!gpu-benchmark

Copy link
Contributor

github-actions bot commented Feb 8, 2024

Benchmark for b694c16

Click to view benchmark
Test Base PR %
LEM Fibonacci Prove - rc = 100/fib/num-100 1463.2±8.39ms 1456.3±9.52ms -0.47%
LEM Fibonacci Prove - rc = 100/fib/num-200 2.8±0.01s 2.8±0.01s 0.00%
LEM Fibonacci Prove - rc = 600/fib/num-100 1838.7±3.28ms 1838.9±12.43ms +0.01%
LEM Fibonacci Prove - rc = 600/fib/num-200 3.0±0.02s 3.0±0.02s 0.00%

porcuquine
porcuquine previously approved these changes Feb 8, 2024
@arthurpaulino arthurpaulino added this pull request to the merge queue Feb 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 8, 2024
@arthurpaulino arthurpaulino added this pull request to the merge queue Feb 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 8, 2024
samuelburnham
samuelburnham previously approved these changes Feb 9, 2024
@arthurpaulino arthurpaulino added this pull request to the merge queue Feb 9, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 9, 2024
huitseeker
huitseeker previously approved these changes Feb 9, 2024
Cargo.toml Outdated Show resolved Hide resolved
@arthurpaulino arthurpaulino added this pull request to the merge queue Feb 9, 2024
Merged via the queue into main with commit 362d044 Feb 9, 2024
11 checks passed
@arthurpaulino arthurpaulino deleted the ap/forgotten-witnesses branch February 9, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants