refactor: Nova structs become generic on their field type (+ update Nova) #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huitseeker
force-pushed
the
make_nova_generic
branch
4 times, most recently
from
f796c6c
to
5ee1226
Compare
huitseeker
changed the title
- makes all of our Nova-related structures generic in the type of the used primary scalar field, provided the field can be attached to a curve cycle with the suitable properties - sets up the curve cycle attachments for the pallas::Scalar and bn256::Scalar fields, - allows us to start using bn256. - making public parameter caching generic, - making clutch generic, or supporting SnarkPack, - making fcomm generic, or supporting SnarkPack, - making the repl generic. - Implemented the `CurveCycleEquipped` trait, replacing previous curve-specific scalar types for improved generic programming over curve cycles. - Updated various files, including `fcomm.rs`, `lurk_proof.rs`, `lib.rs` and `nova.rs` to accommodate the new `CurveCycleEquipped` type. - Extended `LanguageField` enum with `BN256` and `Grumpkin` values and updated respective `fmt` display. - Refactored the `public_params` function in `public_parameters/mod.rs and registry.rs` to use the new `CurveCycleEquipped` type. - Modified proofs in `nova.rs` to work with the new `CurveCycleEquipped` type. - Removed `nova` and `pasta_curves::pallas` dependencies from `lurk-tests.rs` and `registry.rs` respectively, demonstrating reduction in dependency.
huitseeker
force-pushed
the
make_nova_generic
branch
from
5ee1226
to
ccc7a30
Compare
huitseeker
changed the title
porcuquine
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this Does
CurveCyleEquippedtrait)pallas::Scalarandbn256::Scalarfields,What This Does Not Do, but helps with (as the present PR is a blocker for those tasks)
nova::PublicParams)clutchgeneric, or supporting SnarkPack (it still depends on Nova throughnova::NovaProver)fcommgeneric, or supporting SnarkPack (Genericize fcomm proof backends #281, it still depends on Nova throughnova::NovaProver)nova::Proof)In Detail
CurveCycleEquippedtrait, replacing previous curve-specific scalar types for improved generic programming over curve cycles.fcomm.rs,lurk_proof.rs,lib.rsandnova.rsto accommodate the newCurveCycleEquippedtype.LanguageFieldenum withBN256andGrumpkinvalues and updated respectivefmtdisplay.public_paramsfunction inpublic_parameters/mod.rs and registry.rsto use the newCurveCycleEquippedtype.nova.rsto work with the newCurveCycleEquippedtype.novaandpasta_curves::pallasdependencies fromlurk-tests.rsandregistry.rsrespectively, demonstrating reduction in dependency.Closes #519.