Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows proving for incomplete computations #572

Merged
merged 2 commits into from
Aug 2, 2023
Merged

Conversation

arthurpaulino
Copy link
Member

This PR also brings in other improvements:

  • Use more basic building blocks for Evaluator::eval in order to avoid unnecessary clones. This speeds up evaluation:
eval_benchmark/eval_go_base_bls12/_10_16
                        time:   [540.20 µs 541.31 µs 542.61 µs]
                        change: [-13.016% -12.822% -12.564%] (p = 0.00 < 0.05)
                        Performance has improved.
eval_benchmark/eval_go_base_pallas/_10_16
                        time:   [539.73 µs 540.17 µs 540.57 µs]
                        change: [-14.290% -13.874% -13.618%] (p = 0.00 < 0.05)
                        Performance has improved.
eval_benchmark/eval_go_base_bls12/_10_160
                        time:   [5.1792 ms 5.1861 ms 5.1932 ms]
                        change: [-13.298% -13.154% -13.015%] (p = 0.00 < 0.05)
                        Performance has improved.
eval_benchmark/eval_go_base_pallas/_10_160
                        time:   [5.1816 ms 5.1878 ms 5.1949 ms]
                        change: [-13.680% -13.468% -13.298%] (p = 0.00 < 0.05)
                        Performance has improved.
  • Fix off-by-1 errors when logging because the last frame wasn't being logged when the computation just reached the iteration limit
  • Removes a \n in the logs to make them more compact vertically

Closes #526

Comment on lines -595 to -604
"set-limit" => {
let limit = self.peek_usize(cmd, args)?;
validate_non_zero("limit", limit)?;
self.limit = limit;
}
"set-rc" => {
let rc = self.peek_usize(cmd, args)?;
validate_non_zero("rc", rc)?;
self.rc = rc;
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are not meta Lurk. But the feature should be added back in later when we have changeable REPL configs

@huitseeker huitseeker added this pull request to the merge queue Aug 2, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 2, 2023
@huitseeker huitseeker added this pull request to the merge queue Aug 2, 2023
Merged via the queue into master with commit 7f6bb1f Aug 2, 2023
10 checks passed
@huitseeker huitseeker deleted the ap/issue-526 branch August 2, 2023 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix/implement proofs for incomplete computations
3 participants