Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solve CLI parse order bug #574

Merged
merged 2 commits into from
Aug 1, 2023
Merged

Solve CLI parse order bug #574

merged 2 commits into from
Aug 1, 2023

Conversation

arthurpaulino
Copy link
Member

Close #557

@arthurpaulino arthurpaulino requested a review from a team as a code owner July 30, 2023 13:51
@arthurpaulino arthurpaulino mentioned this pull request Jul 30, 2023
Closed
huitseeker
huitseeker reviewed Jul 30, 2023
View reviewed changes
Copy link
Member

@huitseeker huitseeker left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have smoke tests for the basic lurk invocation (tests/lurkrs-smoke-test.rs‎) and the same for clutch (clutch/tests/clutch-smoke-test.rs). Would it be possible to take this occasion to write a couple more to test the arguably not always intuitive passthrough semantics between CLI & REPL?

@arthurpaulino
Copy link
Member Author

arthurpaulino commented Jul 30, 2023 •
edited
Loading

We have smoke tests for the basic lurk invocation (tests/lurkrs-smoke-test.rs‎) and the same for clutch (clutch/tests/clutch-smoke-test.rs). Would it be possible to take this occasion to write a couple more to test the arguably not always intuitive passthrough semantics between CLI & REPL?

I will write an issue for it, but I think it can be done in another PR

@arthurpaulino
Copy link
Member Author

@huitseeker I've added test_repl_command for this PR (to validate the fix).

But I'll write an issue with the proper scope for the full blown task

huitseeker
huitseeker approved these changes Jul 30, 2023
View reviewed changes
Copy link
Member

@huitseeker huitseeker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough, thanks a lot for the fix!

@samuelburnham samuelburnham added this pull request to the merge queue Aug 1, 2023
Merged via the queue into master with commit e22c786 Aug 1, 2023
10 checks passed
@samuelburnham samuelburnham deleted the ap/issue-557 branch August 1, 2023 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelburnham samuelburnham samuelburnham approved these changes

@huitseeker huitseeker huitseeker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lurk repl CLI command fails with arguments
3 participants
@arthurpaulino @huitseeker @samuelburnham