Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Transition to self-hosted runners #598

Merged
merged 2 commits into from
Aug 14, 2023

Conversation

samuelburnham
Copy link
Member

@samuelburnham samuelburnham commented Aug 10, 2023

  • Removes arm64 job on CircleCI as we are already testing on ARM via M1 Mac, and I'm not sure we need first-class support for ARM on Linux.
  • Moves linux_release CircleCI job to self-hosted GH Actions as linux_ignored
  • Runs above linux_ignored on merge_group only, as it is expensive to run and seems wasteful to trigger on every PR commit. This is a speculative change and fine to revert, but it may cause bottlenecks on the self-hosted runners.
  • Moves the nightly linux_exhaustive CircleCI job to self-hosted GH Actions. The cron job currently runs at midnight UTC time, perhaps it would be better in a timezone like ET?
  • Splits CUDA tests into parallel CUDA and OpenCL builds to use scaled GPU runners, and removes the dependency on CC=gcc-10 CXX=g++-10 due to the new CUDA-enabled Docker image in Switch to CUDA base image gh-actions-runner#12. This closes ci: GPU runners require CC=gcc-10 CXX=g++-10 with CUDA 11.5 #597

Fixes #504

@samuelburnham samuelburnham requested a review from a team as a code owner August 10, 2023 16:05
Copy link
Member

@huitseeker huitseeker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm OK with all those tests, except perhaps the removal of ARM linux:

@porcuquine
Copy link
Collaborator

All else equal, I don't favor reducing test surface — especially if this has actually uncovered errors. There was also this: supranational/blst@4f9d557#diff-78a8613e47fd3a587897556bdbcaf5c3b1bd53400cbd57f01322c98f2ebe1147 — thought that was indeed M1.

If we're certain the M1 coverage would catch all the same bugs of this category, and the cost savings warrant it, then removing seems okay. If the cost is relatively minor, I'd generally favor keeping it. I think given the full range of use cases, Lurk on a raspberry pi is not even entirely far-fetched — even if not used for heavy proving…

@porcuquine
Copy link
Collaborator

And yes, to @huitseeker's point about cloud hardware. Basically, I think explicit support is worthwhile.

huitseeker
huitseeker previously approved these changes Aug 13, 2023
Copy link
Member

@huitseeker huitseeker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@huitseeker huitseeker added this pull request to the merge queue Aug 13, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 13, 2023
@huitseeker huitseeker added this pull request to the merge queue Aug 13, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 13, 2023
@huitseeker huitseeker dismissed their stale review August 13, 2023 21:39

CI failures are a bit concerning

Copy link
Member

@huitseeker huitseeker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once more unto the breach ...

@huitseeker huitseeker added this pull request to the merge queue Aug 14, 2023
Merged via the queue into argumentcomputer:master with commit 98edfbb Aug 14, 2023
6 checks passed
@samuelburnham samuelburnham deleted the simplify-ci branch October 25, 2023 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants