chore: Set up clippy to avoid creeping annotations #602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
huitseeker
commented
Aug 12, 2023
huitseeker
commented
- cleans up clippy attributes we don't use, and use the facilities we already have (clippy.toml, .cargo/config) for the ones we do,
- rejects casts for which there is a better (non-cast, safe) alternative.
huitseeker
force-pushed
the
tune_clippy
branch
from
86216e5
to
e76fcd0
Compare
samuelburnham
previously approved these changes
Aug 13, 2023
huitseeker
changed the title
huitseeker
force-pushed
the
tune_clippy
branch
8 times, most recently
from
a4cb80d
to
f5c3ef6
Compare
- Removed split linting warnings across multiple files, removing clippy::too_many_arguments allowances - Modified the clippy lint settings, denying previously allowed lints, and used config to enforce prior behavior
This fires when there is a guaranteed lossless type conversion that could replace a cast.
huitseeker
force-pushed
the
tune_clippy
branch
from
f5c3ef6
to
ef36337
Compare
- Corrected lifetime specifications in `BenchmarkGroup` for all benchmarking functions in `fibonacci.rs` and `synthesis.rs`. - Added `-Wrust_2018_idioms` lint to the `xclippy` alias in the `.cargo` config, and removed thenredundant `rust_2018_idioms` from the deny lint attributes in the library root.
huitseeker
force-pushed
the
tune_clippy
branch
from
1d1dd96
to
4e2bb2e
Compare
…e this with cargo - Adds the `Eq` trait to derive macros a series of data structures across multiple files, - Strictened linting rules by implementing a new clippy lint check for unpaired `PartialEq` and `Eq` derivations,
- Lint is designed to identify and flag instances of large types being passed by value
- Incorporates lint checks for specific behaviors including needless borrows, misuse of ok_or, and unused lifetimes. chore: set up checked conversions lint
- Implement an update to the `to_string()` function usage in `init_lurk_state` for efficiency. - Modify the creation of hex strings in `parse_unicode` for efficiency. - Include `inefficient_to_string` lint checker
- Enhanced Rust's Clippy linting capabilities by adding four new lints: `filter_map_next`, `flat_map_option`, `map_flatten`, and `map_unwrap_or` in `.cargo/config` file.
porcuquine
reviewed
Aug 17, 2023
| @@ -1,3 +1,4 @@ | |||
| type-complexity-threshold = 999 | |||
There was a problem hiding this comment.
As Bodil would say "I have the power of Oleg!"
(also, this is quite sedate, barely 4x the default)
porcuquine
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.