Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Replace dbg! macro with log::debug across modules #619

Closed
wants to merge 1 commit into from

Conversation

huitseeker
Copy link
Member

@huitseeker huitseeker commented Aug 17, 2023

  • Replaced usage of dbg! debugging macros with log::debug across various files,
  • Included dbg_macro to the list of project-wide clippy lints for code quality assurance.

Helps #614

@huitseeker huitseeker requested review from porcuquine and a team as code owners August 17, 2023 21:21
- Replaced usage of `dbg!` debugging macros with `log::debug` across various files,
- Included `dbg_macro` to the list of project-wide clippy lints for code quality assurance.
@winston-h-zhang
Copy link
Member

winston-h-zhang commented Aug 21, 2023

@huitseeker I just saw this, but #627 might be already completing the task you want to move towards, by replacing dbg! (or here log::debug!) with tracing::debug!. If this isn't the case, I'll work in your changes on #627 after this is merged

@huitseeker
Copy link
Member Author

@winston-h-zhang #627, once it is complete and passes tests, should indeed be an advantageous replacement for this.
Note: I'll want to see the use of the dbg! macro forbidden by CI, and the present PR shows how to achieve that.

@huitseeker huitseeker closed this Aug 22, 2023
auto-merge was automatically disabled August 22, 2023 16:35

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants