refactor: Enhance error handling and messaging across modules #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huitseeker
force-pushed
the
map_err_loss
branch
from
7911236
to
46eb1d7
Compare
huitseeker
force-pushed
the
map_err_loss
branch
from
46eb1d7
to
a259db1
Compare
huitseeker
force-pushed
the
map_err_loss
branch
from
40e630c
to
fe0a50a
Compare
Closed
huitseeker
force-pushed
the
map_err_loss
branch
5 times, most recently
from
075e89e
to
4991b4c
Compare
porcuquine
previously approved these changes
Sep 20, 2023
- Enhanced clarity and detail of error messages in multiple modules (`clutch/src/lib.rs`, `fcomm/src/lib.rs`, `src/z_data/z_ptr.rs`, and `src/public_parameters/mem_cache.rs`). - This includes displaying previously-silenced specific errors in proof key generation, expression/environment reading, base32 decoding, and disk write errors in the public parameters module.
- Enhanced error handling in `verify` function within `clutch/src/lib.rs` to improve program stability.
- Updated import specifications across numerous files for clarity:, these include changes to `backend.rs`, `circuit.rs`, `path.rs`, `eval.rs`, `macros.rs`, and `pointers.rs`. - Modified and refactored code for improved error handling, examples include changes to `interpreter.rs`, `mod.rs`, `var_map.rs`, `writer.rs`, `store.rs`. - Included implementation of Debug traits in `var_map.rs` and `zstore.rs`. - Enhanced handling of invalid u16 values in `Tag` implementation - Implemented several lint checks in `.cargo/config` to ensure code quality. - Refined match syntax in the `num_paths_taken` method on `path.rs` and `fetch_symbol_path`, `read_maybe_meta`, `hash_ptr` on `store.rs` for better performance and error handling.
huitseeker
force-pushed
the
map_err_loss
branch
from
4991b4c
to
f2e247d
Compare
porcuquine
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clutch/src/lib.rs,fcomm/src/lib.rs,src/z_data/z_ptr.rs, andsrc/public_parameters/mem_cache.rs).map_err_ignorein project-wide Clippy lints in.cargo/configto increase overall quality of error handling.Edit (Sept 17)
This now includes #673 :
if lets in cases where it's more concise, and assortedOption/ResultcombinatorsEdit (Sept 19)
&mutparameters