Isolate some changes from #629 #663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arthurpaulino
force-pushed
the
prepare-for-integration
branch
from
a3bac88
to
502e0c6
Compare
arthurpaulino
changed the title
huitseeker
previously approved these changes
Sep 13, 2023
Comment on lines
+83
to
+93
| #[inline] | ||
| fn get_allocated_const(&self, f: F) -> Result<&AllocatedNum<F>> { | ||
| self.0 | ||
| .get(&FWrap(f)) | ||
| .ok_or_else(|| anyhow!("Global allocation not found for {}", f.hex_digits())) | ||
| } | ||
|
|
||
| #[inline] | ||
| fn get_allocated_const_cloned(&self, f: F) -> Result<AllocatedNum<F>> { | ||
| self.get_allocated_const(f).cloned() | ||
| } |
There was a problem hiding this comment.
Nit: two suggestions, C-GETTER, and C-CALLER_CONTROL which hints that get_allocated_const would perhaps suffice.
There was a problem hiding this comment.
Without the cloned version, I would have to manually write clone() outside many many times. It's better to have this shortcut to avoid repeating myself
emmorais
previously approved these changes
Sep 13, 2023
arthurpaulino
dismissed stale reviews from emmorais and huitseeker
via
6391af9
arthurpaulino
force-pushed
the
prepare-for-integration
branch
from
502e0c6
to
6391af9
Compare
huitseeker
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Storefor synthesis (literals have to be interned beforehand)GlobalAllocatorfor synthesis (global constants have to be allocated beforehand)MatchValfor a simplerMatchSymbolMatchValandMatchSymbolLeaftoAtomin the context of pointersStoreZStoreinfra for LEM