Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Ptr hashing functions pure #813

Merged
merged 1 commit into from
Nov 1, 2023
Merged

Conversation

arthurpaulino
Copy link
Member

Pointer hashing functions used to throw errors when the data needed for hashing wouldn't be found in the store. However, this indicates a malformed store, meaning that interning must have gone wrong somewhere else. So a straightforward panic is more adequate.

This simplifies a lot of calls to Store::hash_ptr, which were being unwrapd or expectd in many cases anyway.

@arthurpaulino arthurpaulino requested review from a team as code owners October 30, 2023 20:50
Copy link
Member

@huitseeker huitseeker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup!

@arthurpaulino
Copy link
Member Author

!benchmark
!gpu-benchmark

Copy link
Contributor

github-actions bot commented Nov 1, 2023

Benchmark for ef9a71f

Click to view benchmark
Test Base PR %
LEM Prove/Fibonacci-rc=100/num-100/a791459ea98ed014859282c673e2f3ad4505c98e-2023-10-31 12.2±0.15s N/A N/A
LEM Prove/Fibonacci-rc=100/num-100/ef9a71f1954ae8b2e339782896cd821b2ec5353e-2023-10-31 12.3±0.11s N/A N/A
LEM Prove/Fibonacci-rc=100/num-200/a791459ea98ed014859282c673e2f3ad4505c98e-2023-10-31 24.4±0.85s N/A N/A
LEM Prove/Fibonacci-rc=100/num-200/ef9a71f1954ae8b2e339782896cd821b2ec5353e-2023-10-31 24.2±0.19s N/A N/A

@arthurpaulino arthurpaulino added this pull request to the merge queue Nov 1, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Nov 1, 2023
@arthurpaulino arthurpaulino added this pull request to the merge queue Nov 1, 2023
Merged via the queue into master with commit ba7fc55 Nov 1, 2023
15 checks passed
@arthurpaulino arthurpaulino deleted the ap/simplify-ptr-hashing branch November 1, 2023 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants