ci: Parameterize BenchmarkId on output type in PR bench comments
#829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelburnham
force-pushed
the
ci-bench-comment-context
branch
from
ac36984
to
23c283b
Compare
huitseeker
approved these changes
Nov 1, 2023
Comment on lines
+64
to
+77
| let output_type = bench_parameters_env().unwrap_or("stdout".into()); | ||
| match output_type.as_ref() { | ||
| "pr-comment" => format!("num-{}", self.fib_n), | ||
| "commit-comment" => todo!(), | ||
| "gh-pages" => todo!(), | ||
| _ => format!("num-{}/{}-{}", self.fib_n, self.sha, self.date), | ||
| } | ||
| } | ||
| } | ||
|
|
||
| fn bench_parameters_env() -> anyhow::Result<String> { | ||
| std::env::var("LURK_BENCH_OUTPUT") | ||
| .map_err(|e| anyhow!("Noise threshold env var isn't set: {e}")) | ||
| } |
There was a problem hiding this comment.
At this stage, this probably indicates we want to document what folks are allowed to put in the variables defined in the env file.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
LURK_BENCH_OUTPUTenv var, which enables customization of thefibonacci_lemBenchmarkIdfor differently formatted output types.Problem:
boa-dev/criterion-compare-actionPR comment is printing incorrectly: #825 (comment).critcmpcan't compare benchmarks with differentBenchmarkId's, and ourfibonacci_lembenchmark includes the commit hash in the ID.Solution: Remove the commit hash for the
pr-commentoutput type, and keep it for the other types for now.