Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor more hash cache logic from Lurk Alpha #901

Merged
merged 5 commits into from
Nov 17, 2023

Conversation

huitseeker
Copy link
Member

@huitseeker huitseeker commented Nov 16, 2023

This removes:

  • unused list-destructuring gadgets from circuit_frame, thinking they may be superseded by those included in More progress towards Alpha cleanup #849. This is mostly a straw man to get one of @arthurpaulino / @gabriel-barrett to tell me those are, in fact, still needed (in which case I'm happy to elide the commit).
  • simplifies a lot of the hash stub caching logic in hash_witness, which is by now unused. This is a straw man to make @arthurpaulino / @gabriel-barrett tell me why ContName::NeverUsed is still used.

@huitseeker huitseeker changed the title Straw man removals WIP: Straw man removals Nov 16, 2023
@arthurpaulino
Copy link
Member

  • Yes, that was the goal of More progress towards Alpha cleanup #849. With the building blocks it introduced, we're able to construct and deconstruct almost any kind of data LEM can represent. It's missing hide/open, but we can add that later, on demand.
  • I don't know why ContName::NeverUsed is still used. We don't use ContName in LEM.

@huitseeker huitseeker changed the title WIP: Straw man removals WIP: more removals Nov 17, 2023
@huitseeker huitseeker changed the title WIP: more removals Refactor more hash cache logic from Lurk Alpha Nov 17, 2023
@huitseeker huitseeker marked this pull request as ready for review November 17, 2023 00:18
@huitseeker huitseeker requested a review from a team as a code owner November 17, 2023 00:18
@huitseeker huitseeker added this pull request to the merge queue Nov 17, 2023
Merged via the queue into argumentcomputer:main with commit d372ffd Nov 17, 2023
22 of 24 checks passed
@huitseeker huitseeker deleted the more_removals branch November 17, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants