-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New throughput performance example #908
Conversation
0f25ffd
to
1038714
Compare
1038714
to
0b9b8a7
Compare
96fb4f1
to
ae27c73
Compare
1bf76b2
to
44db63b
Compare
303b277
to
30a7925
Compare
30a7925
to
6061ee8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we're already using this as an 'indicator' of something, I think it's fine to merge (though I would like to fix the 'source-code case' issue as a matter of good policy in examples) as-is. Before we start taking it too seriously, it would be useful to document the intended behavior and the implementation so:
- users know exactly what this purports to measure
- reviewers can verify that it actually does so
This review claims to have done neither of those but notes that as an n+1 'number go up' example, we're already getting some benefit out of running it from time to time.
… rcs and number of folding steps
6061ee8
to
4fba2f9
Compare
Add example to measure throughput in it/s (raw and adjusted) across different rcs and number of folding steps
This is a PoC that we might want to later integrate with
criterion
somehow.On a short run with
LURK_RC=8,16 LURK_N_FOLDS=2 cargo run --release --example tp_table
, it prints:Note: these numbers are from my weak machine.