Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GPU accelerated Grumpkin MSM #965

Merged
merged 1 commit into from
Dec 22, 2023
Merged

GPU accelerated Grumpkin MSM #965

merged 1 commit into from
Dec 22, 2023

Conversation

winston-h-zhang
Copy link
Member

Requires argumentcomputer/arecibo#187 upstream

@winston-h-zhang winston-h-zhang requested a review from a team as a code owner December 15, 2023 21:26
huitseeker
huitseeker reviewed Dec 20, 2023
View reviewed changes
Copy link
Member

@huitseeker huitseeker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need:

  • a refresh of the CI run once the upstream branch is ready,
  • an additional commit changing the dependency back to the main branch (even if it breaks CI), once the CI run above passes.

huitseeker
huitseeker requested changes Dec 21, 2023
View reviewed changes
Copy link
Member

@huitseeker huitseeker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The feature name is obsolete.

huitseeker
huitseeker reviewed Dec 21, 2023
View reviewed changes
Copy link
Member

@huitseeker huitseeker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not stamping now, because if I did, pushing a commit with the branch redirected to dev would discard my stamp.
But this looks good!

@winston-h-zhang
Copy link
Member Author

arecibo is already redirected at dev

@huitseeker
Copy link
Member

@winston-h-zhang oh, I got confused because CI is passing! Which makes sense, of course, in this particular case, but is a bit unusual for a companion PR.

@huitseeker huitseeker added this pull request to the merge queue Dec 22, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 22, 2023
github-actions bot pushed a commit that referenced this pull request Dec 22, 2023
@huitseeker @github-actions
[automated] GPU Benchmark from PR #965
83b166e
@huitseeker huitseeker added this pull request to the merge queue Dec 22, 2023
github-actions bot pushed a commit that referenced this pull request Dec 22, 2023
@huitseeker @github-actions
[automated] GPU Benchmark from PR #965
bac8d11
Merged via the queue into main with commit 0a4960a Dec 22, 2023
12 checks passed
@huitseeker huitseeker deleted the grumpkin-msm branch December 22, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huitseeker huitseeker huitseeker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@winston-h-zhang @huitseeker