Expectation tests #974
Merged
Expectation tests #974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
porcuquine
approved these changes
Dec 19, 2023
There was a problem hiding this comment.
Excellent. Thank you for getting to this. I would also be open to doing this for constraint and variable counts in circuits, as long as we have the appropriate guardrails and continue to orient to those as values whose changes should only be intentional and noted with close attention.
huitseeker
pushed a commit
to huitseeker/lurk-rs
that referenced
this pull request
Dec 20, 2023
* Expectation tests for eval * Expectation test for nova * clippy --------- Co-authored-by: Gabriel Barreto <gabriel.aquino.barreto@gmail.com>
huitseeker
added a commit
that referenced
this pull request
Dec 20, 2023
* Simplified `Func` and `Cproc` call (#966) * Expectation tests (#974) * Expectation tests for eval * Expectation test for nova * clippy --------- Co-authored-by: Gabriel Barreto <gabriel.aquino.barreto@gmail.com> * use expect_test to make assertions about circuit properties (#978) * Fix version (#977) * chore: Release * update README --------- Co-authored-by: François Garillot <francois@garillot.net> * Cleanup before patch release (#984) * chore: remove peekmore - Removed `peekmore` dependency from the project * refactor: (automated) Refactor of code for readability and style improvements - Modified the project-level lints in `.cargo/config`, added more lints enhance maintainability. - corrected the code in function, mostly through clippy. * chore: Release --------- Co-authored-by: Gabriel Barreto <gabriel.aquino.barreto@gmail.com> Co-authored-by: Arthur Paulino <arthurleonardo.ap@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adapts the expected iterations on our evaluation and proving tests to use expect_test, which automatically updates the expected values if
cargo testis called withUPDATE_EXPECT=1.It was implemented in a way that prevents the auto-update if the computed iterations is greater than the expected iterations, making it easier for us to maintain a model that is not supposed to become slower.