Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version #977

Merged
merged 2 commits into from
Dec 19, 2023
Merged

Fix version #977

merged 2 commits into from
Dec 19, 2023

Conversation

arthurpaulino
Copy link
Member

No description provided.

@arthurpaulino arthurpaulino linked an issue Dec 19, 2023 that may be closed by this pull request
Cargo.toml Show resolved Hide resolved
Copy link
Member

@huitseeker huitseeker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last commit is great, but the three prior ones should either:

  • not be there,
  • or leave the main branch in the state they found it, that is with the dependencies of the lurk-lab repos pointing to git dependencies rather than to crates.io packages (even if the intermediary commits between first and last say otherwise)

Cargo.toml Show resolved Hide resolved
@arthurpaulino arthurpaulino marked this pull request as ready for review December 19, 2023 21:14
@arthurpaulino arthurpaulino requested a review from a team as a code owner December 19, 2023 21:14
@huitseeker huitseeker added this pull request to the merge queue Dec 19, 2023
github-actions bot pushed a commit that referenced this pull request Dec 19, 2023
Merged via the queue into main with commit 3ab302f Dec 19, 2023
12 checks passed
@huitseeker huitseeker deleted the fix-version branch December 19, 2023 22:51
huitseeker added a commit to huitseeker/lurk-rs that referenced this pull request Dec 20, 2023
* chore: Release

* update README

---------

Co-authored-by: François Garillot <francois@garillot.net>
huitseeker added a commit that referenced this pull request Dec 20, 2023
* Simplified `Func` and `Cproc` call (#966)

* Expectation tests (#974)

* Expectation tests for eval

* Expectation test for nova

* clippy

---------

Co-authored-by: Gabriel Barreto <gabriel.aquino.barreto@gmail.com>

* use expect_test to make assertions about circuit properties (#978)

* Fix version (#977)

* chore: Release

* update README

---------

Co-authored-by: François Garillot <francois@garillot.net>

* Cleanup before patch release (#984)

* chore: remove peekmore

- Removed `peekmore` dependency from the project

* refactor: (automated) Refactor of code for readability and style improvements

- Modified the project-level lints in `.cargo/config`, added more lints enhance  maintainability.
- corrected the code in function, mostly through clippy.

* chore: Release

---------

Co-authored-by: Gabriel Barreto <gabriel.aquino.barreto@gmail.com>
Co-authored-by: Arthur Paulino <arthurleonardo.ap@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[LUR-10] Versioning and Readme fixes
3 participants