Refactor: remove useless component from evaluation functions #994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabriel-barrett
previously approved these changes
Dec 21, 2023
arthurpaulino
force-pushed
the
remove-useless-return-component
branch
from
1611b7f
to
c27fd90
Compare
* Since #887, the number of iterations on evaluation is precisely the number of frames * Remove `iterations` component from evaluation functions that return the frames Note: this component was being ignored in most places already
arthurpaulino
force-pushed
the
remove-useless-return-component
branch
from
c27fd90
to
eacd076
Compare
huitseeker
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
iterationscomponent from evaluation functions that return the framesNote: this component was being ignored in most places already