Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standard Circom Gadget with Keccak example #997

Merged
merged 24 commits into from
Mar 13, 2024
Merged

Standard Circom Gadget with Keccak example #997

merged 24 commits into from
Mar 13, 2024

Commits on Mar 13, 2024

  1. chore: ignore Jetbrain config folder

    @tchataigner
    tchataigner committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    9868dc8 View commit details
    Browse the repository at this point in the history

  2. feat(circom): CLI import with author/name 

    Circom circuit are now imported under a reference composed by author/name. As this format is the one used to point to Github repository, it will allow us to have a seemless workflow for local and distant Gadgets.
    @tchataigner
    tchataigner committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    b2cc56e View commit details
    Browse the repository at this point in the history

  3. feat(circom): adapt current circom implem 

    Adapted the current CircomCoprocessor implementation to properly handle reference instead of name only. Also adapted the circom.rs example to use them.
    @tchataigner
    tchataigner committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    1f4a04f View commit details
    Browse the repository at this point in the history

  4. feat(circom): default local and fallback remote 

    - With the new implementation, we first try to fetc hthe gadget locally and fallback on remote when needed.
- Introduced a version over Circom Gadgets. Useful to point to a particular remote release.
- Better error propagation
- Precise error message based on where the flow is failing
    @tchataigner
    tchataigner committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    1ec6a5d View commit details
    Browse the repository at this point in the history

  5. docs(circom): README to explain behavior of Circom Coproc & Gadget

    @tchataigner
    tchataigner committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    3e7c781 View commit details
    Browse the repository at this point in the history

  6. docs(circom): added link to template gadget

    @tchataigner
    tchataigner committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    0630e29 View commit details
    Browse the repository at this point in the history

  7. docs(circom): wip example keccak 

    This is WIP as there is a need to fix circom-scotia before being able to make the Keccak example work.

- Update framework -> stack in the README
- Create an example skeleton for a remote Keccak example
- Fix the circom example to use an imported Circom Gadget from the CLI
    @tchataigner
    tchataigner committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    dc9cc1c View commit details
    Browse the repository at this point in the history

  8. fix(circom): fixed CI test 

    - Removed deleted keccak mod
- Fixed clippy warning
    @tchataigner
    tchataigner committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    6bb752c View commit details
    Browse the repository at this point in the history

  9. fix(circom): fixed clippy in examples

    @tchataigner
    tchataigner committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    9ac4a17 View commit details
    Browse the repository at this point in the history

  10. feat(circom): wip review 

    - Adapted circom-scotia to use main instead of dev
- Created a structure, CircomReference to qualify an identifier for CircomGadget
- Better check on CircomReference initialization
    @tchataigner
    tchataigner committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    db3e647 View commit details
    Browse the repository at this point in the history

  11. feat(circom): wip argument from lurk 

    Arity is now inherited directly from the gadget, making it declarative by the gadget developer.
    @tchataigner
    tchataigner committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    e6efcff View commit details
    Browse the repository at this point in the history

  12. feat(circom): trying out AllocatedPtr and Var

    @tchataigner
    tchataigner committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    1abf895 View commit details
    Browse the repository at this point in the history

  13. feat(circom): wip working on evaluation values

    @tchataigner
    tchataigner committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    e86ee6e View commit details
    Browse the repository at this point in the history

  14. refactor(circom): wip making list work

    @tchataigner
    tchataigner committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    946d57e View commit details
    Browse the repository at this point in the history

  15. feature(circom): working keccak example

    @tchataigner
    tchataigner committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    c071a6c View commit details
    Browse the repository at this point in the history

  16. feature(circom): only keeping one example

    @tchataigner
    tchataigner committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    7ba3139 View commit details
    Browse the repository at this point in the history

  17. refactor(circom): fix xclippy

    @tchataigner
    tchataigner committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    6067c4c View commit details
    Browse the repository at this point in the history

  18. refactor(circom): fix wasm build

    @tchataigner
    tchataigner committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    a45b636 View commit details
    Browse the repository at this point in the history

  19. refactor(circom): integrate review & adapt chain_car_cdr

    @tchataigner
    tchataigner committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    c941350 View commit details
    Browse the repository at this point in the history

  20. refactor(circom): remove unecessary todos

    @tchataigner
    tchataigner committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    ccaec9b View commit details
    Browse the repository at this point in the history

  21. refactor(circom): to bits le on alloc num

    @tchataigner
    tchataigner committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    cca3bf7 View commit details
    Browse the repository at this point in the history

  22. Update src/coprocessor/circom/mod.rs 

    Co-authored-by: François Garillot <4142+huitseeker@users.noreply.github.com>
    @tchataigner @huitseeker
    tchataigner and huitseeker committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    0d77ddd View commit details
    Browse the repository at this point in the history

  23. refactor(circom): using bellpepper utils

    @tchataigner
    tchataigner committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    85d4897 View commit details
    Browse the repository at this point in the history

  24. fix(circom): using proper commit for lurk lib

    @tchataigner
    tchataigner committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    faaf71d View commit details
    Browse the repository at this point in the history