adding disableStart option for Picker.Date.Range #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I added three options to the PickerDate control. These affect the time picker specifically. The options are: minHour: 0, maxHour: 23, hourStart: '01', If the user sets minHour and maxHour through a PickerDate object, he/she can set the time limits to choose times with timewheel, for example officehours, 8AM to 6PM. Then, the hourStart, a bit of a luxury, make it easier for the user to choose a time. Also, when a second PickerDate object, which is destined to specify an ending date and tie for an event, the time in the timewheel can be initialized to one hour after the PickarDate starting event object was selected to. Feedback?
I added a new property for the Picker.Date.Range object: disableStart. The idea behind this option is to prevent users from inadvertently changing the start date field value. Without this option, in cases where the Picker.Date.Range object has been initialized to start at a certain date, and if the user clicks more than once over the Picker.Date.Range control, the start date field value is likely to change. With the implementation of the disableStart option, and when this option is set to true, the start date input from the Picker.Date.Range control is attributed readonly, i.e. disables the user from selecting this input field, and despite the number of clicks over the Picker.Date.Range control, the start date field's value will remain the initialized value.
| @@ -66,8 +67,11 @@ Picker.Date.Range = new Class({ | |||
| if (event.key == 'enter') self.selectRange(); | |||
| } | |||
| }; | |||
|
|
|||
| var startInput = this.startInput = new Element('input', {events: events}).inject(footer); | |||
| var inputProperties = new Object(); | |||
There was a problem hiding this comment.
Simply use:
{
events: events,
readonly: readOnly
// etc.
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea behind the option I propose, view code through my fork modification of file Picker.Date.Range.js, is to prevent users from inadvertently changing the start date field value. When the Picker.Date.Range object has been initialized to start at a certain date, the value is likely to change if the user clicks more than once over the Picker.Date.Range control. With the implementation of the disableStart option, and when this option is set to true, the start date input from the Picker.Date.Range control is attributed readonly, i.e. disables the user from selecting this input field, and despite the number of clicks over the Picker.Date.Range control, the start date field's value will remain the initialized value.