Adding ampm option to enable 12hr time select for the time picker #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabling the ampm option allows the user to use 12 hour time as input in the timepicker. This is accomplished by adding an "AM PM" radio button below the hour and minute in the timepicker.
I added a demo page for this feature under Test/timepicker12hr.html. I also modified the css for each theme to allow this to work.
As a side note:
I ran into a bizarre issue where the am/pm radio buttons were getting instantly reset after the user clicks on them. I got around this by delaying the change of the radio buttons by 100ms after the user click on them, which works but is kind of a hack. Regardless, I can't figure out what in the source could be causing this weird resetting behavior. Any ideas what could be the cause?