Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #679 #687

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Revert #679 #687

merged 1 commit into from
Oct 4, 2023

Conversation

mmagician
Copy link
Member

Revert "Pseduo-remove MapToCurve::new, renamed to check_parameters (#679)"

This reverts commit 85546e4.

Description

@drskalman This should do it right?

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (master)
  • Linked to GitHub issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the GitHub PR explorer

@mmagician mmagician requested review from a team as code owners October 4, 2023 08:14
@mmagician mmagician requested review from z-tech, Pratyush and weikengchen and removed request for a team October 4, 2023 08:14
@Pratyush Pratyush merged commit 5dfeedf into arkworks-rs:master Oct 4, 2023
15 checks passed
@mmagician mmagician deleted the revert-new-removal branch October 4, 2023 16:14
aleasims pushed a commit to NilFoundation/arkworks-algebra that referenced this pull request Oct 18, 2023
Co-authored-by: Jeff Burdges <burdges@gnunet.org>
aleasims added a commit to NilFoundation/arkworks-algebra that referenced this pull request Oct 18, 2023
mmagician added a commit to mmagician/algebra that referenced this pull request Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants