This repository has been archived by the owner on Dec 18, 2023. It is now read-only.
Non-canonical infinity point & bad flags in BLS12-381 serialization should fail #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks @ArnaudBrousseau for the test
ArnaudBrousseau
approved these changes
Sep 8, 2023
There was a problem hiding this comment.
The new flag logic and tests look good to me! Thanks for taking this on so quickly @mmagician!
Pratyush
approved these changes
Sep 8, 2023
|
Thanks for the great PR @mmagician! Could you add a CHANGELOG entry as this is an important fix? Thanks! |
|
@Pratyush It's actually a breaking change no? |
|
In Rust breaking changes are only when the API changes, not necessarily behaviour |
|
@Pratyush Thanks, I moved it to |
Pratyush
approved these changes
Sep 11, 2023
Shigoto-dev19
pushed a commit
to Shigoto-dev19/ark-babyjub
that referenced
this pull request
Sep 23, 2023
…hould fail (arkworks-rs#176) Co-authored-by: Kevaundray Wedderburn <kevtheappdev@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #157, the original is stale.
Thanks @ArnaudBrousseau for providing a test for bad flags (lmk if you'd like me to add you as co-author on the commit here)
closes: #157
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
Pendingsection inCHANGELOG.mdFiles changedin the Github PR explorer