Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Release 0.5 (#50)" #51

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Revert "Release 0.5 (#50)" #51

merged 1 commit into from
Oct 28, 2024

Conversation

Pratyush
Copy link
Member

@Pratyush Pratyush commented Oct 28, 2024

Description

Accidentally merged it #50 prematurely, but I think we want to merge a PR that replaces ark-std::error::Error with core::error::Error unconditionally.


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (master)
  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

This reverts commit 371710b.
@Pratyush Pratyush merged commit f42738d into master Oct 28, 2024
4 checks passed
@Pratyush Pratyush deleted the revert-50-release-0.5 branch October 28, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant