Fix issue #832 #847
Open
Fix issue #832 #847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
38
commented
Jun 5, 2020
| @@ -187,5 +187,5 @@ CHRPOS SingleLineDelimTextFileReader::getVcfSVlen() { | |||
| } | |||
| } | |||
| // not found | |||
| return INT_MIN; | |||
| return 1; | |||
There was a problem hiding this comment.
As long as other place in bedtools doesn't handles negative length (which means returning INT_MIN would only causing interger overflow which cause unpredictable bugs rather than anything we expected), I believe return INT_MIN doesn't make sense anyway. Alternatively, we can turn this into an error, but I am not sure if this is actually valid VCF
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes issue #832