Skip to content
This repository has been archived by the owner on Oct 11, 2020. It is now read-only.

Add support for multi workspace workflow #11

Draft
wants to merge 1 commit into
base: prometheansacrifice/reason-rewrite
Choose a base branch
from

Conversation

wokalski
Copy link

This PR contains changes needed for multi folder workspaces support. Unfortunately I'm struggling to debug an issue with it. When you open a workspace with at least two folders, the plugin correctly creates a second client for the folder but every subsequent edit for files inside the second folder ends up with:

Notification handler 'textDocument/publishDiagnostics' failed with message: Illegal argument: character must be non-negative

Does it ring a bell?

@ManasJayanth
Copy link
Collaborator

@wokalski Anything else in the logs? What is the LSP server sending you? Just to get an idea. Things are moving fast with the language server too

@wokalski
Copy link
Author

wokalski commented Jan 1, 2020

I didn’t have time to investigate further. But it seems like an issue on this end. I’ll debug when I come back from vacation.

@wokalski
Copy link
Author

wokalski commented Jan 1, 2020

But nothing else is in the logs. There might be something wrong with the caching logic and maybe the extension winds up using the same lsp server for both workspace folders

@ManasJayanth
Copy link
Collaborator

This will probably close #30

@wokalski
Copy link
Author

I'm gonna take a look at this now.

@wokalski
Copy link
Author

I'll wait for #36 with this because I have a gut feeling they might be related.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants