Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull request temporary for Interop #2

Closed
wants to merge 14 commits into from
Closed

Conversation

arunjose696
Copy link
Owner

What do these changes do?

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves #?
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

anmyachev and others added 14 commits June 17, 2024 13:12
…d 3.11 on a scheduled basis (modin-project#7289)

Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
…ting metadata in 'read_csv' (modin-project#7322)

Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
…odin-project#7319)

Bumps the github-actions group with 3 updates: [actions/cache](https://github.com/actions/cache), [Slashgear/action-check-pr-title](https://github.com/slashgear/action-check-pr-title) and [github/codeql-action](https://github.com/github/codeql-action).


Updates `actions/cache` from 2 to 4
- [Release notes](https://github.com/actions/cache/releases)
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
- [Commits](actions/cache@v2...v4)

Updates `Slashgear/action-check-pr-title` from 3.0.0 to 4.3.0
- [Release notes](https://github.com/slashgear/action-check-pr-title/releases)
- [Commits](Slashgear/action-check-pr-title@v3.0.0...v4.3.0)

Updates `github/codeql-action` from 2 to 3
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@v2...v3)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: github-actions
- dependency-name: Slashgear/action-check-pr-title
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: github-actions
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: github-actions
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…DataFrames are small (modin-project#7323)

Signed-off-by: Jayson Willey <91502167+Jayson729@users.noreply.github.com>
Signed-off-by: Vikram Sreekanti <vsreekanti@gmail.com>
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
Signed-off-by: Kirill Suvorov <kirill.suvorov@intel.com>
…ct#7330)

Signed-off-by: Igoshev, Iaroslav <iaroslav.igoshev@intel.com>
modin-project#7336)

Signed-off-by: Chi-Sheng Liu <chishengliu@chishengliu.com>
@arunjose696 arunjose696 changed the base branch from main to arun-sqc July 11, 2024 07:50
)
md_kwargs, pd_kwargs = {}, {}

def execute_callable(fn, inplace=False, md_kwargs={}, pd_kwargs={}):

Check notice

Code scanning / CodeQL

Explicit returns mixed with implicit (fall through) returns Note test

Mixing implicit and explicit returns may indicate an error as implicit returns always return None.
modin_series_without_index, _ = create_test_series(
np.arange(col_len), data_frame_mode=data_frame_mode_pair[1]
)
modin_df @ modin_series_without_index

Check notice

Code scanning / CodeQL

Statement has no effect Note test

This statement has no effect.
from modin.core.storage_formats.base.query_compiler import BaseQueryCompiler
from modin.utils import (
MODIN_UNNAMED_SERIES_LABEL,
_inherit_docstrings,
try_cast_to_pandas,
)

from .query_compiler_validator import QueryCompilerTypeCaster

Check notice

Code scanning / CodeQL

Cyclic import Note

Import of module
modin.core.storage_formats.pandas.query_compiler_validator
begins an import cycle.
from types import FunctionType, MethodType
from typing import Any, Dict, Tuple, TypeVar

from modin.core.storage_formats.base.query_compiler import BaseQueryCompiler

Check notice

Code scanning / CodeQL

Cyclic import Note

Import of module
modin.core.storage_formats.base.query_compiler
begins an import cycle.
try:
operation()
# `except` for non callable attributes
except TypeError:

Check notice

Code scanning / CodeQL

Empty except Note test

'except' clause does nothing but pass and there is no explanatory comment.
eval_general(
(modin_df1, modin_df2),
(pandas_df1, pandas_df2),
lambda dfs: dfs[0].merge(dfs[1], on=on),

Check failure

Code scanning / CodeQL

Loop variable capture Error test

Capture of loop variable
on
.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants