Enhancement: Add CoreCompoments and update assets structure #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Got some build things to fix. |
esdrasedu
force-pushed
the
fix_heroicon
branch
3 times, most recently
from
e89f5c2
to
1a146d6
Compare
|
@zachdaniel CI fixed, should you review it again, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR update the assets and add
CoreCompomentstoo.Following the new Phoenix guide, I have add
CoreCompoments, you can read more about this module here https://hexdocs.pm/phoenix/components.html#corecomponentsAnother change is the way assets are manage, Phoenix now is handle assets from whappers instead of npm and webpack, you can read more here https://hexdocs.pm/phoenix/asset_management.html
Any improve or fix, please let me know.