-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Rust support in 'aspect init' #125
Conversation
@illicitonion first thing I'm missing is: how do you run the |
97249cf
to
3eb144e
Compare
@alexeagle Ok, I've fixed up a few things, and got this working some - I'm thinking (and please add/comment/edit): rustfmt via rules_lintThis should Just Work, but we can do some testing and make sure the UX is as desired We should make sure the correct editions are being used per-target clippy via rules_lintcc @mrmeku and aspect-build/rules_lint#385 VS Code integration via rust-analyzerIf we're defaulting to "just lay stuff out like Cargo would expect", rust-analyzer should just work out of the box with nothing special. But in general, rules_rust offers a target: protobufWe have a choice to make here between using We could probably put together a "use rules_proto, and Version stampingWe should probably make the sample app be a rules_oci image example |
We don't have any sample apps in this setup right now. It would be neat to scaffold those out but it should be a separate effort and include the existing languages |
I forgot to say, yay, very cool :) |
c96f5d9
to
5fd34e2
Compare
Goals: