Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: smoke-test running pnpm #141

Merged
merged 4 commits into from
Sep 20, 2024
Merged

chore: smoke-test running pnpm #141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6c78ca3
Update WORKSPACE.bazel
alexeagle Sep 20, 2024
552a5af
chore: smoke-test running pnpm
alexeagle Sep 20, 2024
b114dc3
chore: fix
alexeagle Sep 20, 2024
4c8f80b
list instead of install
alexeagle Sep 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,6 @@ jobs:
strategy:
matrix:
scaffold-version:
# Aspect CLI prior to Sept 2024 used this version.
# Preserve compat until we think everyone has upgraded.
- v0.0.99
- v0.3.0
preset:
- kitchen-sink
Expand All @@ -21,6 +18,11 @@ jobs:
- py
- cpp
- minimal
include:
alexeagle marked this conversation as resolved.
Show resolved Hide resolved
# Aspect CLI prior to Sept 2024 used this version.
# Preserve compat until we think everyone has upgraded.
- scaffold-version: v0.0.99
preset: kitchen-sink
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
Expand Down Expand Up @@ -55,10 +57,16 @@ jobs:
working-directory: "${{ steps.scaffold.outputs.dir }}"
run: git diff --exit-code

- run: bazel run @rules_go//go mod tidy
- name: Go smoke test
run: ./tools/go mod tidy
working-directory: "${{ steps.scaffold.outputs.dir }}"
if: "${{ matrix.preset == 'go' }}"


- name: JS smoke test
run: ./tools/pnpm list
working-directory: "${{ steps.scaffold.outputs.dir }}"
if: "${{ matrix.preset == 'js' }}"

- run: bazel lint ...
working-directory: "${{ steps.scaffold.outputs.dir }}"

Expand Down
1 change: 1 addition & 0 deletions {{ .ProjectSnake }}/WORKSPACE.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
#
# This file is a marker indicating the root of a Bazel workspace.
# See MODULE.bazel for dependency information.
# NB: after ibazel supports MODULE.bazel as the marker, this file may no longer be needed.
alexeagle marked this conversation as resolved.
Show resolved Hide resolved
{{if and .Scaffold.lint .Computed.java -}}
load("@aspect_rules_lint//lint:pmd.bzl", "fetch_pmd")

Expand Down
2 changes: 1 addition & 1 deletion {{ .ProjectSnake }}/tools/_run_under_cwd.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,4 @@ case "$(basename "$0")" in
;;
esac
# NB: we don't use 'bazel run' because it may leave behind zombie processes under ibazel
bazel 2>/dev/null build "$target" && BAZEL_BINDIR=. exec $(bazel info execution_root)/$(bazel 2>/dev/null cquery --output=files "$target") "$@"
bazel 2>/dev/null build --build_runfile_links "$target" && BAZEL_BINDIR=. exec $(bazel info execution_root)/$(bazel 2>/dev/null cquery --output=files "$target") "$@"
Loading