Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: wire up protobuf if requested #30

Merged
merged 1 commit into from
May 24, 2024
Merged

feat: wire up protobuf if requested #30

merged 1 commit into from
May 24, 2024

Conversation

alexeagle
Copy link
Member


Changes are visible to end-users: yes

  • Searched for relevant documentation and updated as needed: yes
  • Breaking change (forces users to change their own code or config): yes
  • Suggested release notes appear below: yes

Now prompts for whether protobuf should be setup. If so, it also registers proto_lang_toolchain for requested languages.

Test plan

  • Covered by existing test cases

@alexeagle alexeagle requested a review from thesayyn May 24, 2024 18:20
@alexeagle alexeagle force-pushed the proto branch 2 times, most recently from 5782e79 to 107bbe2 Compare May 24, 2024 18:22
Copy link
Member

@thesayyn thesayyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dream come true! Absolute beauty.

@alexeagle alexeagle force-pushed the proto branch 3 times, most recently from ddf347c to cb98438 Compare May 24, 2024 18:36
@alexeagle alexeagle merged commit d46f05a into main May 24, 2024
5 checks passed
@alexeagle alexeagle deleted the proto branch May 24, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants