refactor(python): support multiple requirements.in #56
Conversation
alexeagle
force-pushed
the
pyproject_deps
branch
3 times, most recently
from
29ac674
to
cdf7d39
Compare
|
@jab FYI, does this meet your expectations? Note that I don't bother pinning Also LMK if you're interested in being a collaborator on this repo! |
alexeagle
force-pushed
the
pyproject_deps
branch
4 times, most recently
from
07078ee
to
dd48064
Compare
This allows the non-Bazel workflow to still pin or install test dependencies in isolation
alexeagle
force-pushed
the
pyproject_deps
branch
from
dd48064
to
bb9c537
Compare
My hunch is that starting with just runtime.txt and all.txt (as you've done here) sufficiently covers the main goal here, and it's nice to avoid the complexity of an additional test.txt. Not unreasonable to expect a user who needs that intermediate lockfile to figure out how to generate it based on what's now generated out-of-the-box, IMO.
Sure, thanks! |
Co-authored-by: Joshua Bronson <jabronson@gmail.com>
Co-authored-by: Joshua Bronson <jabronson@gmail.com>
Co-authored-by: Joshua Bronson <jabronson@gmail.com>
| requirements_in = "pyproject.toml", | ||
| requirements_txt = "requirements_lock.txt", | ||
| ) | ||
|
|
||
| # Fetches metadata for python packages we depend on. |
There was a problem hiding this comment.
@alexeagle, were these changes missing
+exports_files(["pyproject.toml"])?
I just tried aspect init for the first time since this PR was merged. Immediately running ./repin.sh (making no changes to what was generated) resulted in
ERROR: /private/var/folders/_t/xpfjyxwx727_zrtwcrhyfyjm0000gn/T/tmp.uBVmFZpqkL/foo/BUILD.bazel: no such target '//:pyproject.toml': target 'pyproject.toml' not declared in package '' defined by /private/var/folders/_t/xpfjyxwx727_zrtwcrhyfyjm0000gn/T/tmp.uBVmFZpqkL/foo/BUILD.bazel; however, a source file of this name exists. (Perhaps add 'exports_files(["pyproject.toml"])' to /BUILD?)
There was a problem hiding this comment.
Ugh, some missing tests then. PR should have been red. I'll try to add this week
This allows the non-Bazel workflow to still pin or install test dependencies in isolation.
Note that install of
pytestis intentional to prepare for adding somepy_testworkflow next.Now that there's yet another
updatecommand required when dependencies change, I've introduced arepin.shscript. This can be the cheap version of aspect-build/aspect-cli#687 - when we like the DX I can bake the result into Aspect CLI.