Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize Docker services: use only FrankenPHP, add cli service #21

Merged
merged 6 commits into from
Oct 17, 2024

Conversation

chuckadams
Copy link
Contributor

Pull Request

What changed?

  • There is now just one docker-compose stack, using FrankenPHP
  • A cli service now exists for running one-off commands.
  • bin/dcrun exists to shorten the whole docker compose run --rm cli foofrah.
  • bin/dcexec also exists for docker compose exec
    • note dcexec execs on the webapp service by default, as the cli service is not persistent

Why did it change?

Fewer config choices means less maintenance headache. The cli container will be versatile and handy.

Did you fix any specific issues?

none, this came from a slack conversation with @sarah-savage

CERTIFICATION

By opening this pull request, I do agree to abide by
the CODE OF CONDUCT and be bound by the terms
of the Contribution Guidelines in effect on the date and time
of my contribution as proven by the
revision information in GitHub. I also agree that any previous contributions shall be deemed subject to the terms of the
version in effect on the date and time of this pull request, or any future revisions for pull requests I may submit.
Further, I certify that this work is my own, is original, does not violate the intellectual property of any other person
or entity, and I am not violating any license agreements or contracts I have with any person or entity. Finally, I agree
that this code may be licensed under any license deemed appropraite by AspirePress, including but not
limited to open source, closed source, proprietary or custom licenses, and that such license terms neither violate my
rights or my copyright to this code.

Copy link
Member

@sarah-savage sarah-savage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. r+

@chuckadams chuckadams merged commit 3df42bb into main Oct 17, 2024
1 check passed
@chuckadams chuckadams deleted the chuck/dev/reorg_docker branch October 17, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants