Minor changes to provide correct settings for dev enviornment #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Removed the .env file from the Docker configuration so its read locally and changes to it are immediately reflected. * Updated the DB name in the Docker configuration
chuckadams
added a commit
that referenced
this pull request
Oct 19, 2024
* refactor: wipe out mezzio installation prior to installing Laravel * refactor: install laravel * fix: push attic'd composer.json that didn't make it into commit * Adding several improvements (#23) * Added improvements around Phinx and migrations * Created Franken as our main PHP source * Rewrote the Makefile to use the CLI and work properly * build: regenerate lockfile * fix(build): move migrations to require-dev so laravel doesnt choke on it * feat: add mailhog service * chore: tweak sample config * fix: port make targets around db and migrations * temp: add phinx migrations to attic * fix: fix make list target formatting * chore: port initial schema migration * chore: roll in remaining migrations * chore: publish cors config * temp: rm the rest of .ATTIC * Minor changes to provide correct settings for dev enviornment (#24) * Removed the .env file from the Docker configuration so its read locally and changes to it are immediately reflected. * Updated the DB name in the Docker configuration * fix: add correct DB environment vars to .env.example * fix: api.aspirepress.local -> api.aspirecloud.local in docker-compose.yml * feat: add generate-key target to Makefile * feat: add stub api routes file * Adding quality tools and fixing coding style * Added Pint for CS fixing * Added Larastan for code quality and set Level 6 with a baseline * Fixed minor style issues * Updating running checks to build the CLI container and then the Makefile with Pest * Fixing a style issue detected * Generating app key for tests Note that eventually we'll have to pass a host of config vars to effectively test the Laravel instance. That's TBD for later. * Add Catch All handler (#25) * fix: rm catchall route in api.php * style: fix style to make pint happy * Populating the .env file if it doesn't exist * fix: give phpstan proper args in check target * fix: phpstan qa issues --------- Co-authored-by: Chuck Adams <cja987@gmail.com> Co-authored-by: Matthew Zalewski <matthew@minion.co.nz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor changes to provide correct settings for dev enviornment