Increase code coverage

assaabloy-ppi · Mar 7, 2018 · 15d8f88 · 15d8f88
1 parent 89e0106
commit 15d8f88
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 4 deletions.
diff --git a/src/salt.c b/src/salt.c
@@ -133,7 +133,7 @@ salt_ret_t salt_protocols_append(salt_protocols_t *p_protocols,
                                  uint8_t size)
 {
 
-    if (NULL == p_protocols) {
+    if ((NULL == p_protocols) || (NULL == p_buffer)) {
         return SALT_ERROR;
     }
 

diff --git a/tests/a1a2.c b/tests/a1a2.c
@@ -120,11 +120,13 @@ static void a1a2_known_host(void **state)
 
     host_ret = salt_create_signature(host_channel);
     assert_true(host_ret == SALT_SUCCESS);
-    host_ret = salt_init_session(host_channel, host_buffer, SALT_HNDSHK_BUFFER_SIZE);
-    assert_true(host_ret == SALT_SUCCESS);
 
-    uint8_t protocol_buf[128];
+    uint8_t protocol_buf[67];
     salt_protocols_t my_protocols;
+
+    host_ret = salt_protocols_init(host_channel, &my_protocols, protocol_buf, 8);
+    assert_true(host_ret == SALT_ERROR);
+
     host_ret = salt_protocols_init(host_channel, &my_protocols, protocol_buf, sizeof(protocol_buf));
     assert_true(host_ret == SALT_SUCCESS);
     host_ret = salt_protocols_append(&my_protocols, "Echo", 4);
@@ -134,6 +136,21 @@ static void a1a2_known_host(void **state)
     host_ret = salt_protocols_append(&my_protocols, "Sensor", 6);
     assert_true(host_ret == SALT_SUCCESS);
 
+    host_ret = salt_protocols_append(&my_protocols, "Sensor", 6);
+    assert_true(host_ret == SALT_ERROR);
+
+    host_ret = salt_protocols_append(NULL, "Sensor", 6);
+    assert_true(host_ret == SALT_ERROR);
+
+    host_ret = salt_protocols_append(&my_protocols, NULL, 6);
+    assert_true(host_ret == SALT_ERROR);
+
+    host_ret = salt_protocols_append(&my_protocols, "Sensor", sizeof(salt_protocol_t) + 1);
+    assert_true(host_ret == SALT_ERROR);
+
+    host_ret = salt_init_session(host_channel, host_buffer, SALT_HNDSHK_BUFFER_SIZE);
+    assert_true(host_ret == SALT_SUCCESS);
+
     client_ret = salt_create_signature(client_channel);
     assert_true(client_ret == SALT_SUCCESS);
     client_ret = salt_init_session(client_channel, client_buffer, SALT_HNDSHK_BUFFER_SIZE);